Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronizing with Effects #457

Merged
merged 4 commits into from May 12, 2023
Merged

Synchronizing with Effects #457

merged 4 commits into from May 12, 2023

Conversation

tdd
Copy link
Collaborator

@tdd tdd commented Apr 26, 2023

Trad intégrale (pfiou !)

Bon, faut encore que je fasse ma propre repasse intégrale (d'où le statut Draft), mais pour ce genre de mammouths (1500+ lignes), j'apprécierais au moins 2 relectures soignées les copains 😉

@tdd tdd added Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR scope:required-pages Part of the required translations before we can ship translator:seasoned The author of that translation is a seasoned React docs translator labels Apr 26, 2023
@tdd tdd requested review from JeremiePat, sheplu and Nab69 April 26, 2023 14:08
@tdd tdd self-assigned this Apr 26, 2023
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.16 KB (🟡 +14 B) 169.78 KB
/500 76.15 KB (🟡 +14 B) 169.78 KB
/[[...markdownPath]] 77.57 KB (🟡 +14 B) 171.2 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.37 KB (🟡 +11 B) 170 KB
/500 76.37 KB (🟡 +11 B) 169.99 KB
/[[...markdownPath]] 77.79 KB (🟡 +11 B) 171.42 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@tdd
Copy link
Collaborator Author

tdd commented Apr 28, 2023

Coucou @sheplu @Nab69 @JeremiePat ! L'un de vous pourrait-il consacrer un (bon) moment à me relire ça pour que je merge ? Merci mille fois !

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.4 KB (🟡 +35 B) 170.02 KB
/500 76.39 KB (🟡 +35 B) 170.02 KB
/[[...markdownPath]] 77.81 KB (🟡 +35 B) 171.44 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@tdd tdd added Reviewing Un mainteneur qualifié est en train de composer la revue de code and removed Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR labels May 11, 2023
@tdd
Copy link
Collaborator Author

tdd commented May 11, 2023

Hello tous. Bon, je refais une repasse visuelle / typo / ortho / relecture et je merge, ça attend des reviews tierces depuis trop longtemps, on va avancer 😉

@github-actions
Copy link

github-actions bot commented May 11, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.69 KB (🟡 +40 B) 170.31 KB
/500 76.68 KB (🟡 +40 B) 170.31 KB
/[[...markdownPath]] 78.11 KB (🟡 +40 B) 171.73 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@tdd tdd added Reviewed and removed Reviewing Un mainteneur qualifié est en train de composer la revue de code labels May 12, 2023
@tdd tdd merged commit 034d362 into main May 12, 2023
4 checks passed
@tdd tdd deleted the copy/sync-with-effects branch May 12, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed scope:required-pages Part of the required translations before we can ship translator:seasoned The author of that translation is a seasoned React docs translator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant