Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 translation page faq-state #57

Merged
merged 9 commits into from Mar 12, 2019
Merged

🌐 translation page faq-state #57

merged 9 commits into from Mar 12, 2019

Conversation

lbelavoir
Copy link
Contributor

Bonjour,

Traduction de la page Component State.

Un doute sur la traduction de Parent et Child ou non.

@Nab69 Nab69 added the Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR label Feb 20, 2019
content/docs/faq-state.md Outdated Show resolved Hide resolved
content/docs/faq-state.md Outdated Show resolved Hide resolved
content/docs/faq-state.md Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Feb 26, 2019

Deploy preview for fr-reactjs ready!

Built with commit b47e1b2

https://deploy-preview-57--fr-reactjs.netlify.com

@JeremiePat JeremiePat added the Reviewing Un mainteneur qualifié est en train de composer la revue de code label Mar 5, 2019
Copy link
Collaborator

@JeremiePat JeremiePat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut :)

Quelque point de détails, mais comme d'habitude, c'est très plaisant à lire.

content/docs/faq-state.md Outdated Show resolved Hide resolved
content/docs/faq-state.md Outdated Show resolved Hide resolved
content/docs/faq-state.md Outdated Show resolved Hide resolved
@JeremiePat JeremiePat added Reviewed and removed Reviewing Un mainteneur qualifié est en train de composer la revue de code labels Mar 5, 2019
JeremiePat and others added 3 commits March 5, 2019 10:03
Co-Authored-By: lbelavoir <lbelavoir@users.noreply.github.com>
Co-Authored-By: lbelavoir <lbelavoir@users.noreply.github.com>
Co-Authored-By: lbelavoir <lbelavoir@users.noreply.github.com>
@tdd tdd self-assigned this Mar 8, 2019
Copy link
Collaborator

@tdd tdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut @lbelavoir !

Avant toute chose, merci pour tout ce boulot ! C'est super cool de nous filer un coup de main.

Comme toujours quelques retouches, même si là j'ai remarqué des soucis que tu ne semblais pas avoir ailleurs, récurrents :

  • Cela -> ça
  • Guillemets français
  • Pas mal de tournures très mot-à-mot…

Ça reste très cool, quand même 😎

Tout est fait sous forme de Suggestions GitHub, il te suffit à chaque suggestion que tu approuves de cliquer le bouton d'ajout au lot de modifs à committer, et sur la fin de créer le commit groupé. (ce mode de regroupement en un seul commit est à favoriser absolument, mais tu devras aller dans l'onglet Files changed pour y accéder, il n'est pas utilisable dans l’onglet Conversation)

Si certaines appellent discussion, n'hésite pas, tu réponds, on en parle, on avance ensemble 🤝

Quand tout sera bouclé côté code, je ferai une repasse visuelle finale en local avant de fusionner.

Encore mille mercis, j'ai hâte de voir cette PR finalisée et dans master !

content/docs/faq-state.md Outdated Show resolved Hide resolved
content/docs/faq-state.md Outdated Show resolved Hide resolved
content/docs/faq-state.md Outdated Show resolved Hide resolved
content/docs/faq-state.md Outdated Show resolved Hide resolved
content/docs/faq-state.md Outdated Show resolved Hide resolved
content/docs/faq-state.md Outdated Show resolved Hide resolved
content/docs/faq-state.md Outdated Show resolved Hide resolved
content/docs/faq-state.md Outdated Show resolved Hide resolved

[Maybe.](https://redux.js.org/faq/general#when-should-i-use-redux)
[Peut-être.](https://redux.js.org/faq/general#when-should-i-use-redux)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😁

content/docs/faq-state.md Outdated Show resolved Hide resolved
@tdd tdd removed the Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR label Mar 12, 2019
Co-Authored-By: lbelavoir <lbelavoir@users.noreply.github.com>
@tdd tdd merged commit 826623e into reactjs:master Mar 12, 2019
@lbelavoir lbelavoir deleted the faq-state branch March 18, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants