Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faq structure #62

Merged
merged 11 commits into from Mar 12, 2019
Merged

Faq structure #62

merged 11 commits into from Mar 12, 2019

Conversation

lbelavoir
Copy link
Contributor

Big hesitation between Existe-t-il and Y-a-t-il also some translations a bit far away from the original sentence structure but I have found them more "real"

@netlify
Copy link

netlify bot commented Feb 22, 2019

Deploy preview for fr-reactjs ready!

Built with commit a38468e

https://deploy-preview-62--fr-reactjs.netlify.com

@JeremiePat JeremiePat added the Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR label Feb 23, 2019
@lbelavoir lbelavoir marked this pull request as ready for review March 2, 2019 21:47
@JeremiePat JeremiePat added the Reviewing Un mainteneur qualifié est en train de composer la revue de code label Mar 5, 2019
content/docs/faq-structure.md Outdated Show resolved Hide resolved
content/docs/faq-structure.md Outdated Show resolved Hide resolved
content/docs/faq-structure.md Outdated Show resolved Hide resolved
content/docs/faq-structure.md Outdated Show resolved Hide resolved
content/docs/faq-structure.md Outdated Show resolved Hide resolved
@JeremiePat
Copy link
Collaborator

Salut :)

Je t'ai fait quelque propositions de reformulation pour alléger quelques tournures mais globalement ta traduction est plaisante à lire.

@JeremiePat JeremiePat added Reviewed and removed Reviewing Un mainteneur qualifié est en train de composer la revue de code labels Mar 5, 2019
JeremiePat and others added 5 commits March 5, 2019 10:18
Co-Authored-By: lbelavoir <lbelavoir@users.noreply.github.com>
Co-Authored-By: lbelavoir <lbelavoir@users.noreply.github.com>
Co-Authored-By: lbelavoir <lbelavoir@users.noreply.github.com>
Co-Authored-By: lbelavoir <lbelavoir@users.noreply.github.com>
Co-Authored-By: lbelavoir <lbelavoir@users.noreply.github.com>
@tdd tdd self-assigned this Mar 8, 2019
Copy link
Collaborator

@tdd tdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut @lbelavoir !

Avant toute chose, merci pour tout ce boulot ! C'est super cool de nous filer un coup de main.

Bon, bin toujours de la typographie, quelques retouches de formulation pour mieux coller au ton originel (dont une qui va bien te faire halluciner je pense 😉), mais au global c'est super 👏

Tout est fait sous forme de Suggestions GitHub, il te suffit à chaque suggestion que tu approuves de cliquer le bouton d'ajout au lot de modifs à committer, et sur la fin de créer le commit groupé. (ce mode de regroupement en un seul commit est à favoriser absolument, mais tu devras aller dans l'onglet Files changed pour y accéder, il n'est pas utilisable dans l’onglet Conversation)

Si certaines appellent discussion, n'hésite pas, tu réponds, on en parle, on avance ensemble 🤝

Quand tout sera bouclé côté code, je ferai une repasse visuelle finale en local avant de fusionner.

Encore mille mercis, j'ai hâte de voir cette PR finalisée et dans master !

content/docs/faq-structure.md Outdated Show resolved Hide resolved
content/docs/faq-structure.md Outdated Show resolved Hide resolved
content/docs/faq-structure.md Outdated Show resolved Hide resolved
content/docs/faq-structure.md Outdated Show resolved Hide resolved
content/docs/faq-structure.md Outdated Show resolved Hide resolved
content/docs/faq-structure.md Outdated Show resolved Hide resolved
content/docs/faq-structure.md Outdated Show resolved Hide resolved
content/docs/faq-structure.md Outdated Show resolved Hide resolved
@tdd tdd removed the Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR label Mar 11, 2019
tdd and others added 2 commits March 11, 2019 22:40
Co-Authored-By: lbelavoir <lbelavoir@users.noreply.github.com>
@tdd tdd merged commit bc47671 into reactjs:master Mar 12, 2019
@lbelavoir lbelavoir deleted the faq-structure branch March 13, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants