Home translation #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
השתמשתי בעברית לא תקנית כמו "קומפילציה" במקום "הידור" כדי שהטקסט יהיה יותר קריא ונגיש
I assume that when finished the layout style will change to `direction:rtl, text-align:right`. When it will the example text with hebrew will look as expected
galnir
requested changes
Feb 14, 2019
galnir
approved these changes
Feb 15, 2019
|
It looks good, just need to solve the punctuation problem before we merge. I'm looking for solutions atm |
|
What do you think about using React in English instead of translating it? From the PR: |
I've looked into other languages repos and they all seem to write 'React' in English |
Where did I translated it? |
gaearon
pushed a commit
that referenced
this pull request
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've chosen readability over correctness. So a few words are not translated (like state) and a few are just visually translated (like component which translated to
קומפוננטהand notרכיב)