Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update composition-vs-inheritance.md #40

Merged
merged 4 commits into from Mar 11, 2019
Merged

Update composition-vs-inheritance.md #40

merged 4 commits into from Mar 11, 2019

Conversation

dormd
Copy link
Contributor

@dormd dormd commented Mar 4, 2019

No description provided.

galtalmor
galtalmor requested changes Mar 4, 2019
View reviewed changes
Copy link
Collaborator

@galtalmor galtalmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good, just a few small suggestions.
Also, in general for readability I would suggest always adding a dash (-) between ל, מ, כ, ב, so on and a word in English.
And lastly, I would try to keep standard quotes and not the special ״ ones

content/docs/composition-vs-inheritance.md Outdated Show resolved Hide resolved
content/docs/composition-vs-inheritance.md Outdated Show resolved Hide resolved
content/docs/composition-vs-inheritance.md Show resolved Hide resolved
content/docs/composition-vs-inheritance.md Outdated Show resolved Hide resolved
@tesseralis tesseralis mentioned this pull request Mar 4, 2019
Closed
88 tasks
@dormd
Copy link
Contributor Author

dormd commented Mar 10, 2019

@galtalmor 👍

@galtalmor galtalmor merged commit 8298bf3 into reactjs:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galtalmor galtalmor galtalmor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dormd @galtalmor