Translate ReactDOMServer page #43
Conversation
|
|
||
| - [`renderToNodeStream()`](#rendertonodestream) | ||
| - [`renderToStaticNodeStream()`](#rendertostaticnodestream) | ||
|
|
||
| * * * | ||
|
|
||
| ## Reference {#reference} | ||
| ## סימוכין {#reference} |
There was a problem hiding this comment.
I think it'll be too complicated for Hebrew readers, but I understand it has a good meaning. I would like to see what other contributors think about it and by the way, we should also add it to the style guide #22
There was a problem hiding this comment.
It doesn't fit in every context of the word, but in this context, as I have to translate it as a header, this is the most suitable translation I found. Wouldn't mind changing it later on if we find a better translation.
There was a problem hiding this comment.
I found some, but I don't think they are a good fit (e.g עיון, התייחסות). What about leaving it as it is?
There was a problem hiding this comment.
I wouldn't want to keep this in English since it is not a technical term and I find this translation to be accurate. I understand it sounds a little legal-ish, but this is the language :)
There was a problem hiding this comment.
We have to remember that our job is to make the reader’s life easier and obviously, in this case, it is not. Let's leave it open for now until we find something else.
| @@ -49,9 +49,9 @@ If you call [`ReactDOM.hydrate()`](/docs/react-dom.html#hydrate) on a node that | |||
| ReactDOMServer.renderToStaticMarkup(element) | |||
| ``` | |||
|
|
|||
| Similar to [`renderToString`](#rendertostring), except this doesn't create extra DOM attributes that React uses internally, such as `data-reactroot`. This is useful if you want to use React as a simple static page generator, as stripping away the extra attributes can save some bytes. | |||
| דומה ל-[`renderToString`](#rendertostring), מלבד העובדה שאינה יוצרת מאפייני DOM נוספים ש-React משתמשת בהם באופן פנימי, כגון `data-reactroot`. אפשרות זו שימושית אם ברצונך להשתמש ב-React כמחולל של דפים סטטיים פשוטים, שכן הסרת המאפיינים הנוספים יכולה לחסוך כמה בתים. | |||
There was a problem hiding this comment.
According to Morfix, there are two options for byte, בית or בייט. I know בית is the Hebrew word but בייט sounds more clear to me. Tell me what do you think about it.
There was a problem hiding this comment.
As far as I know, in most literature I read בית is usually used, this is why I used it as well, also I think it sounds better in plurals. I think it is better than the other option, but if there's a consensus I wouldn't mind changing.
There was a problem hiding this comment.
At first, it confused me, but after I read it twice it was understandable. It doesn't mind to me, but I know it'll be clearer to others.
|
Let's push this in and if we come with better decisions change it in the future. I think there's no point in holding the PR. |
|
Sounds great to me! |
No description provided.