Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate accessibility page #71

Merged
merged 12 commits into from
May 30, 2019
Merged

Translate accessibility page #71

merged 12 commits into from
May 30, 2019

Conversation

rgrnwd
Copy link

@rgrnwd rgrnwd commented May 26, 2019

Issue 1 (Hebrew Translations - Advanced Guides - Accessibility)

@netlify
Copy link

netlify bot commented May 26, 2019 •
edited
Loading

Deploy preview for he-reactjs ready!

Built with commit 381f067

https://deploy-preview-71--he-reactjs.netlify.com

galnir
galnir reviewed May 26, 2019
View reviewed changes
Copy link
Collaborator

@galnir galnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Accessibility is an important subject and you nailed it with the translation.
Before we merge, take a look at the suggestions. There are some missing dashes and very few grammar fixes :)

@rgrnwd
Copy link
Author

rgrnwd commented May 30, 2019

Thanks @galnir for such an extensive response :) will work on it tonight

@galnir
Copy link
Collaborator

galnir commented May 30, 2019

Great, merging 👍

@galnir galnir merged commit 171c374 into reactjs:master May 30, 2019
@tesseralis tesseralis mentioned this pull request Jun 24, 2019
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galnir galnir galnir left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rgrnwd @galnir