Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated your first component #204

Merged

Conversation

Akshit1025
Copy link
Contributor

@Akshit1025 Akshit1025 commented Apr 16, 2022

I have translated the Your First Component page. Please review it

Sections on the page

  • Intro

  • Components: UI Building Blocks

  • Defining a Component

    • Step 1: Export the component
    • Step 2: Define the function
    • Step 3: Add Markup
  • Using a component

    • What the browser sees
    • Nesting and Organising Components
  • Recap

  • Challenge

    • Export the Component
    • Fix the return statement
    • Spot the Mistake
    • Your Own Component

Please let me know if there are any changes that have to be made
Please checkmark these boxes too
Thank You

@Akshit1025
Copy link
Contributor Author

@arshadkazmi42 please review this pull request

Thank You

@arshadkazmi42
Copy link
Member

@arshadkazmi42 please review this pull request

Thank You

@Akshit1025 I have been a bit busy. I will get to it soon. Sorry about the delay

@Akshit1025
Copy link
Contributor Author

@arshadkazmi42 please review this pull request
Thank You

@Akshit1025 I have been a bit busy. I will get to it soon. Sorry about the delay

ok no problem

@arshadkazmi42 arshadkazmi42 self-requested a review May 9, 2022 06:31
@arshadkazmi42 arshadkazmi42 added the 1st Review First phase of review label May 9, 2022
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this.

I have added few comments till line 55

Lets' get these fixed and then I will continue with further review.

You can check for our review guidelines at #23

beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
@Akshit1025
Copy link
Contributor Author

@arshadkazmi42 Hey, I have changed all the typos that you have suggested till now. You can start reviewing further

Thanks

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on the fixes.

I have added more review comments till line 170.

Let's get these fixed, post that we can continue further with the review

beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
@Akshit1025
Copy link
Contributor Author

@arshadkazmi42 I have fixed the typos and now you can further review the translation

@arshadkazmi42
Copy link
Member

@Akshit1025 There are two review comments which still have minor issues. Rest looks fine.

I have marked them as unresolved, can you check and update those? Post that we can continue further.

@arshadkazmi42
Copy link
Member

@Akshit1025 There is still one typo in the code block. Please check the unresolved comment

@Akshit1025
Copy link
Contributor Author

@arshadkazmi42 typos have been fixed. Please carry on

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on the fixes.

I have added review in rest of the file.

Once these are fixed we can get this merged.

beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
beta/src/pages/learn/your-first-component.md Outdated Show resolved Hide resolved
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on the fixes.

I have added review in rest of the file.

Once these are fixed we can get this merged.

@Akshit1025
Copy link
Contributor Author

@arshadkazmi42 all the typos that you have suggested have been completed

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thank you for working on all the fixes.

lets get this merged 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1st Review First phase of review beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants