Translated rendering element page #21
Conversation
|
Deploy preview for hi-reactjs ready! Built with commit 88e00bc |
There was a problem hiding this comment.
@AbhishekCode Great work with the translation.
I have left a couple of feedbacks
For reviewing we follow this process.
- You should not resolve review feedback, you can add a comment or a 👍 emoji to every review comment once its resolved and pushed.
- Reviewer will review the changes and resolve the converstions
content/docs/rendering-elements.md
Outdated
| ```js | ||
| const element = <h1>Hello, world</h1>; | ||
| ``` | ||
|
|
||
| Unlike browser DOM elements, React elements are plain objects, and are cheap to create. React DOM takes care of updating the DOM to match the React elements. | ||
| ब्राउज़र DOM एलेमेंट के विपरीत, React एलेमेंट्स एक सादा ऑब्जेक्ट है और इन्हें बनाना आसान है। React DOM React एलेमेंट्स के अनुसार DOM को अद्यतन बनाए रखता है। |
There was a problem hiding this comment.
एलेमेंट्स => एलिमेंट्स
actually this sounds more relevant, can you change this everywhere
|
Alright working on it |
|
@AbhishekCode any updates on this? |
|
@AbhishekCode Any updates on this? Let us know if you need any help from our end |
* 'master' of https://github.com/AbhishekCode/hi.reactjs.org: (46 commits) Fix explanation of the `useState` example in 'Hooks API Reference' page (#1881) removed sentence since functions can have state (#1878) Bump React versions Add kannada to languages Update languages.yml 📦 NEW: Add React.js Lahore Meetup Group (#1873) Adding immer in the list of immutable libraries (#1839) Added RQ React meetup in Philadelphia (#1866) Remove ReactNYC meetup from the list remove ReactWeek from Conference list (#1864) removed line as functions can have state now too (#1783) Update languages for Simplified Chinese completion (#1854) Document useContext bailout strategy (#1848) Add more explanations to Hooks API page (#1845) Add a DOM measurement recipe to Hooks FAQ (#1843) Add React Rally 2019 (#1840) Fix previous article on hooks-effect.md (#1802) Fix overflowing headers on small screens (#1830) Updating useMemo docs (#1796) Fixing incorrect value for eslint rule (#1824) ... # Conflicts: # yarn.lock
|
@arshadkazmi42 Please review, updated |
There was a problem hiding this comment.
@AbhishekCode Good work with the fixes, you have missed a couple of feedbacks,
Once you are done with those fixes it will be good to go from my end.
To find missed feedbacks, you can check comments above this, all the unresolved feedbacks which does not have 👍 emoji
|
@arshadkazmi42 Hi, Updated as per comment. Please check and let me know. Thanks. |
|
@AbhishekCode there are still a couple of pending feedbacks, check above this comment, all the feedbacks which are not resolved. |
Okay Please check now. |
|
@AbhishekCode are you still working on this? |
|
@arshadkazmi42 should we close this out since there has not been activity for a while on this now? |
|
@saranshkataria I was planning on working on the inactive PRs myself and you can review it, like this we will be able to merge all the PRs and existing efforts will not be wasted. |
|
That would depend if the original contributor allowed access to change things on this branch, else we will have to copy the work and start working on it as a new PR. I can start doing that too |
|
I think we would be having access as its foked from this. If we dont have access, then copying the changes and creating new PR is also a good option |
|
Picking this one up, closing this PR and creating a new one since package json has been changed in this one and that was not needed, Also there are some weird ASCII characters that are there in here which show up in the editor. So creating a new one. @arshadkazmi42 moving this to #41 and fixing the 3 remaining ones as a new commit |
updating rendering elements from #21
Translated "rendering element" page. Please check .