Translating Components and Props page #24
Conversation
|
Deploy preview for hi-reactjs ready! Built with commit 385b535 |
helios1101
changed the title
There was a problem hiding this comment.
Good start.
I have left a few feedbacks.
Also do have a read of our review process at #23
|
I have done the review till line 90, once these are fixed, we will continue the review of next parts |
|
@helios1101 Also in PR description can you add list of all headings similar to how you have added page name |
content/docs/components-and-props.md
Outdated
|
|
||
| ```js | ||
| function sum(a, b) { | ||
| return a + b; | ||
| } | ||
| ``` | ||
|
|
||
| Such functions are called ["pure"](https://en.wikipedia.org/wiki/Pure_function) because they do not attempt to change their inputs, and always return the same result for the same inputs. | ||
| यह फंक्शन्स को हम कहते है ["pure"](https://en.wikipedia.org/wiki/Pure_function) क्योंकि वे अपने इनपुट को बदलने का प्रयास नहीं करते हैं, और हमेशा समान इनपुट के लिए समान परिणाम लौटाते हैं| |
There was a problem hiding this comment.
You missed this one
यह => ऐसे
content/docs/components-and-props.md
Outdated
|
|
||
| ```js | ||
| function sum(a, b) { | ||
| return a + b; | ||
| } | ||
| ``` | ||
|
|
||
| Such functions are called ["pure"](https://en.wikipedia.org/wiki/Pure_function) because they do not attempt to change their inputs, and always return the same result for the same inputs. | ||
| यह फंक्शन्स को हम कहते है ["pure"](https://en.wikipedia.org/wiki/Pure_function) क्योंकि वे अपने इनपुट को बदलने का प्रयास नहीं करते हैं, और हमेशा समान इनपुट के लिए समान परिणाम लौटाते हैं| |
There was a problem hiding this comment.
You missed this one
यह => ऐसे
There was a problem hiding this comment.
Great work. Thank you for working on this and fixing all the review feedback.
Review is done from me.
For second review @saranshkataria can you have a look at this for the second review
content/docs/components-and-props.md
Outdated
|
|
||
| We recommend naming props from the component's own point of view rather than the context in which it is being used. | ||
| Props का नामकरण हम कौम्पोनॅन्टस के अनुसार करने की सलाह देते हैं बजाय उस संदर्भ में किया जाए जिसमें इसका उपयोग किया जा रहा है| |
There was a problem hiding this comment.
can we break this into easier wording instead?
There was a problem hiding this comment.
Couldn't find simple words.
I can just reverse the parts ...will that do ??
There was a problem hiding this comment.
बजाय उस संदर्भ में किया जाए जिसमें इसका उपयोग किया जा रहा है| part is just a bit difficult, could we reword that and split it into 2 sentences that way?
|
Done till {#props-are-read-only}. 1 more section to go after this. So close 👍 |
|
added final set of comments. Almost there 🎆 |
|
@helios1101 any updates on this? |
I'm having my college sessional exams, will revert once it gets over. |
no worries. Good luck! |
@saranshkataria Plz have a look at the commit! |
|
awesome work! Thanks! |
Translating the Components and Props page to Hindi.
Related to #1
Review Progress