Translate entire Composition vs Inheritance page #28
Conversation
apoorvtomar2222
commented
Apr 5, 2019
•
apoorvtomar2222
commented
- Containment @arshadkazmi42
- Specialization @arshadkazmi42
- So What About Inheritance? @arshadkazmi42
|
Deploy preview for hi-reactjs ready! Built with commit 5704acc |
There was a problem hiding this comment.
Great work.
Add some reviews.
Also, read #23 about the review process how we do reviews.
Once you are done with the fixes we can move head with next phase of reviews
|
@arshadkazmi42 |
|
@apoorvtomar2222 Good work with the fixes, you have missed a couple of them and I have added a couple of more, you can check above this comments, all the unresolved feedbacks are not fixed, can you fix all those and add a 👍 emoji to those comments once you are done. I will do another review on feedback changes once you are done |
apoorvtomar2222
changed the title
|
@arshadkazmi42 I have worked on the comments given by you, fixed and pushed them. |
|
@apoorvtomar2222 Awesome. Just three more feedbacks missed. And you will have a go ahead from me 👍 |
@arshadkazmi42 I have fixed those issues, but it's not showing up in the conversation. But it's updated in the file. |
|
@apoorvtomar2222 In conversation it shows everything unless its resolved. I have added url to line numbers in the comment where changes are needed |
|
@apoorvtomar2222 Great going. Just 1 more to go |
There was a problem hiding this comment.
Awesome work. Loved the speed at which you fixed all the reviews.
As per our review process, @saranshkataria will do a second review on this and after that we will get this merged.
Thanks again.
@saranshkataria over to you
@arshadkazmi42 Thanks for your review process. I was not able to get the hang of this conversion as of now, for further translation will keep those point in mind.
|
| @@ -47,9 +47,9 @@ function WelcomeDialog() { | |||
|
|
|||
| **[Try it on CodePen](https://codepen.io/gaearon/pen/ozqNOV?editors=0010)** | |||
|
|
|||
| Anything inside the `<FancyBorder>` JSX tag gets passed into the `FancyBorder` component as a `children` prop. Since `FancyBorder` renders `{props.children}` inside a `<div>`, the passed elements appear in the final output. | |||
| `<FancyBorder>` JSX टैग के अंदर कुछ भी हो, वह `FancyBorder` कौम्पोनॅन्ट में `चिल्ड्रेंस` prop कि तरह पास हो जाता है। क्यूंकि `FancyBorder`, `{props.children}` को `<div>` के अंदर रेंडर करता है, पास्ड एलिमेंट्स अंतिम परिणाम में दिखने लगते है। | |||
There was a problem hiding this comment.
prop कि तरह पास हो -> ki spelling mistake
There was a problem hiding this comment.
पास हो जाता है। -> pass kiya ja sakta hai
There was a problem hiding this comment.
पास्ड एलिमेंट्स -> pass kiye gaye elments
There was a problem hiding this comment.
परिणाम में दिखने लगते है। -> me dekhe ja sakte hain
|
done till #specialization |
@saranshkataria Fixed all the comment till now. Just having confusion with Children as @arshadkazmi42 told me to change it. So need to create a unanimous decision. |
|
@saranshkataria @arshadkazmi42 If we are done with the review we can merge this one. So that I can pick another page ? |
|
@apoorvtomar2222 there is one more para left for review. once the changes are approved by @saranshkataria we will get this merged |
|
added some more review comments |
Done with these changes @saranshkataria |
|
last 2 to go 🎆 |
Done with both :-) |
|
Awesome work @apoorvtomar2222 ! Thank you! And merging this in. |
Thanks, @saranshkataria @arshadkazmi42 for your time. |
