Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home page translation #3

Merged
merged 5 commits into from Feb 11, 2019
Merged

Home page translation #3

merged 5 commits into from Feb 11, 2019

Conversation

saranshkataria
Copy link
Member

Though the home page is not complete, I have translated the 3 sections and I thought of putting this in to break the ice and let people see something in place. Also, this should provide an opportunity to get in some initial feedback, if any.

@arshadkazmi42 thoughts?

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Got few feedbacks about words translation.
I haven't found any links where it says we should not translate React word.
Also I have update some details here #2 about the words which should not be translated. I got this basic list from chinese translation.
We should confirm, about the React word translation and then make required changes in this PR

order: 2
---

We don't make assumptions about the rest of your technology stack, so you can develop new features in React without rewriting existing code.
हम आपके अन्य तकनिकी स्टैक के बारे में धारणा नहीं बनाते हैं। तो आप मौजूदा कोड को फिर से लिखे बिना रिएक्ट में नई सुविधाएँ बना सकते हैं।
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we translating React word?
As you have translated it in this line to रिएक्ट
And in other files its not translated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saranshkataria I think you missed one word here.
You have translated react in this line.

order: 0
---

React makes it painless to create interactive UIs. Design simple views for each state in your application, and React will efficiently update and render just the right components when your data changes.
React में इंटरैक्टिव यूआई बनाना काफी आसान है। अपने ऐप में प्रत्येक व्यू के लिए सरल विचार डिजाइन करें, और React कुशलता से आपके डेटा में बदलाव होने पर सिर्फ सही कौम्पोनॅन्ट को अपडेट और रेंडर करेगा।
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React word is not translated here and its translated in below file.
Let's keep it consistent. Either we will translate the word or we will keep it as it is.

content/home/marketing/learn-once-write-anywhere.md Outdated Show resolved Hide resolved
content/home/marketing/component-based.md Outdated Show resolved Hide resolved
@saranshkataria
Copy link
Member Author

@arshadkazmi42 fixed the translation of DOM. Let's not do react for now, I checked other languages and didn't see it being translated anywhere else as well. If we do that, the translated word might have a different meaning (not the case in hindi though, I agree). But let us keep it consistent for now and if we do decide to translate, it should be a single find and replace all?

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have missed React at once place here
https://github.com/reactjs/hi.reactjs.org/pull/3/files#diff-163f22d7c53a72e8c0ca39b2829960ccR6

In this line React is translated to hindi

order: 2
---

We don't make assumptions about the rest of your technology stack, so you can develop new features in React without rewriting existing code.
हम आपके अन्य तकनिकी स्टैक के बारे में धारणा नहीं बनाते हैं। तो आप मौजूदा कोड को फिर से लिखे बिना रिएक्ट में नई सुविधाएँ बना सकते हैं।
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saranshkataria I think you missed one word here.
You have translated react in this line.

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@arshadkazmi42 arshadkazmi42 merged commit 9f5b3c8 into master Feb 11, 2019
@saranshkataria saranshkataria deleted the home-page-translation branch February 11, 2019 04:16
saranshkataria pushed a commit that referenced this pull request Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants