Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated create new react app page #52

Closed
wants to merge 18 commits into from

Conversation

vishalsodani
Copy link

No description provided.

@netlify
Copy link

netlify bot commented Oct 9, 2019

Deploy preview for hi-reactjs ready!

Built with commit c339b69

https://deploy-preview-52--hi-reactjs.netlify.com

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start.
Added some review feedback till line 30.

Can you work on the fixes. Will start review post that. You read about our review process here #23

content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
@vishalsodani
Copy link
Author

Great start.
Added some review feedback till line 30.

Can you work on the fixes. Will start review post that. You read about our review process here #23

Made the changes as requested. Thanks!

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with the fixes.
I have added review for rest of the file.
Once these are fixed. Its good to go from my end

content/docs/create-a-new-react-app.md Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
content/docs/create-a-new-react-app.md Outdated Show resolved Hide resolved
@arshadkazmi42
Copy link
Member

@vishalsodani I think you have missed couple of feedbacks or are you still working on it.
Let me know once you are done with those.

@vishalsodani
Copy link
Author

@vishalsodani I think you have missed couple of feedbacks or are you still working on it.
Let me know once you are done with those.

Sorry, it seems I missed a lot of feedbacks. Just did some more changes. Please let me know any more changes to be done. Thanks!

@arshadkazmi42
Copy link
Member

@vishalsodani Only two are left.

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thank you for working on the fixes.
For next step, there will be second phase of review done by @saranshkataria

@saranshkataria
Copy link
Member

added comments till {#create-react-app}

@vishalsodani
Copy link
Author

added comments till {#create-react-app}

Please review. Thanks!

@saranshkataria
Copy link
Member

added more comments till {#nextjs}


### Gatsby {#gatsby}

[Gatsby](https://www.gatsbyjs.org/) is the best way to create **static websites** with React. It lets you use React components, but outputs pre-rendered HTML and CSS to guarantee the fastest load time.
React के साथ **स्टैटिक वेबसाइट** बनाने के लिए [Gatsby](https://www.gatsbyjs.org/) सबसे अच्छा तरीका है। यह आपको React कौम्पोनॅन्ट का उपयोग करने देता है, लेकिन सबसे तेज़ लोड समय की गारंटी के लिए HTML और CSS के पहले से रेंडर किए गए आउटपुट देता है।
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

यह आपको React कौम्पोनॅन्ट का उपयोग करने देता है, लेकिन सबसे तेज़ लोड समय की गारंटी के लिए HTML और CSS के पहले से रेंडर किए गए आउटपुट देता है। misses the point about prerendering

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishalsodani you missed this one


- **[Neutrino](https://neutrinojs.org/)** combines the power of [webpack](https://webpack.js.org/) with the simplicity of presets, and includes a preset for [React apps](https://neutrinojs.org/packages/react/) and [React components](https://neutrinojs.org/packages/react-components/).
- **[Neutrino](https://neutrinojs.org/)** प्रीसेट की सादगी के साथ [webpack](https://webpack.js.org/) की शक्ति को जोड़ती है, और इसमें [React apps](https://neutrinojs.org/packages/react/) and [React components](https://neutrinojs.org/packages/react-components/) के लिए एक प्रीसेट शामिल है।
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

प्रीसेटs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps should be in hindi as well as components

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

एक प्रीसेट शामिल-> remove ek

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one too

@saranshkataria
Copy link
Member

added comments till line 74

@arshadkazmi42 arshadkazmi42 added 1st Review First phase of review 2nd Review Second phrase of review and removed 1st Review First phase of review labels Jan 24, 2020
@arshadkazmi42
Copy link
Member

Closing due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants