Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translation: SyntheticEvent #66

Merged
merged 25 commits into from Apr 25, 2020

Conversation

ps0305
Copy link
Contributor

@ps0305 ps0305 commented Jan 22, 2020

Hindi Translation Progress #1

Translation for API Reference => SyntheticEvent

@ps0305 ps0305 requested review from tesseralis and bvaughn and removed request for tesseralis January 22, 2020 14:04
@netlify
Copy link

netlify bot commented Jan 22, 2020

Deploy preview for hi-reactjs ready!

Built with commit 374b838

https://deploy-preview-66--hi-reactjs.netlify.app

@bvaughn bvaughn removed their request for review January 22, 2020 16:09
@bvaughn
Copy link
Contributor

bvaughn commented Jan 22, 2020

Sorry, I can't review this. I don't speak Hindi. 😄

@saranshkataria
Copy link
Member

@bvaughn never too late to learn? ;)
We will do it in the meantime.

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start.

I have added comments till line 193. Lets get these closed, then I will start with further reviews.
Also refer #23 to know more about our review process

content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
@arshadkazmi42 arshadkazmi42 added the 1st Review First phase of review label Jan 24, 2020
@ps0305
Copy link
Contributor Author

ps0305 commented Jan 25, 2020

Great start.

I have added comments till line 193. Lets get these closed, then I will start with further reviews.
Also refer #23 to know more about our review process

updated as marked, can go ahead and review further.

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good going.

Added review for rest of the file. Once these are fixed, it will be good to go from my end.

content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. 🎉
For next step there will be second phase of review done by @saranshkataria
post that we will get this merged

-------EDIT-----

Sorry about this. by mistake selected Request Changes

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. 🎉
For next step there will be second phase of review done by @saranshkataria
post that we will get this merged

@arshadkazmi42 arshadkazmi42 added 2nd Review Second phrase of review and removed 1st Review First phase of review labels Jan 29, 2020
@saranshkataria
Copy link
Member

added comments till {#supported-events}

@saranshkataria
Copy link
Member

@ps0305 sorry for the delay, got busy with some covid stuff. Could you please resolve the conflicts so that I can continue with the review?

@ps0305
Copy link
Contributor Author

ps0305 commented Apr 14, 2020

@ps0305 sorry for the delay, got busy with some covid stuff. Could you please resolve the conflicts so that I can continue with the review?

@saranshkataria: Conflict resolved, you can continue, and take care amid Covid situation.

@saranshkataria
Copy link
Member

added a few more comments

Copy link
Member

@saranshkataria saranshkataria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comments till {#mouse-events}


React normalizes events so that they have consistent properties across different browsers.
React इवेंट्स को सामान्य करता है ताकि उनके विभिन्न ब्राउज़रों में सुसंगत गुण हों।
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

सामान्य could be left as is since the translation changes the meaning

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normalizes is different than normal?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant for it to read normalizes, not सामान्य and not नार्मल . Either in english/hindi works

content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
Copy link
Member

@saranshkataria saranshkataria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comments till {#selection-events}

content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
Copy link
Member

@saranshkataria saranshkataria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of feedback points and this will be good to merge 🎆

@saranshkataria
Copy link
Member

great work 👍
Merging this in. Thanks!

@saranshkataria saranshkataria merged commit 0e29890 into reactjs:master Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2nd Review Second phrase of review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants