Thinking in React translation #27
Conversation
|
Deploy preview for react-docs-hu ready! Built with commit d476e41 |
balazsorban44
changed the title
There was a problem hiding this comment.
OK, there are some obvious typos, some inconsistencies in the translations, those are hard to argue with. Apart from that, I had some "recommendations", and I am up for a discussion about those. @gergely-nagy since there have been a LOT of requested changes, I ask you to go over this as well, so I did not forget something. @n3ko, I don't know if I see the point in the Hungarian images either, but then again, up for a debate. The content/languages.yml does not belong in this PR I think, so you can safely remove it from here.
Co-Authored-By: Balázs Orbán <info@balazsorban.com>
Co-Authored-By: Balázs Orbán <info@balazsorban.com>
Co-Authored-By: Balázs Orbán <info@balazsorban.com>
Co-Authored-By: Balázs Orbán <info@balazsorban.com>
Co-Authored-By: Balázs Orbán <info@balazsorban.com>
This reverts commit 974978d.
Co-Authored-By: Balázs Orbán <info@balazsorban.com>
Co-Authored-By: Balázs Orbán <info@balazsorban.com>
Just an extra space Co-Authored-By: Balázs Orbán <info@balazsorban.com>
|
And since you did not even use the |
|
And I can also see I forgot to address some of your markup changes. As I wrote in a previous comment, although I think I understand your reason behind it, I think we should stick to the original formatting. I can see why the React team decided not to mark every single appearances of In my opinion it is a bit funky/too colorful (distracting even) with all that yellow blobs. Even though I did not make a suggestion comment for these, I kindly ask you to go and please revert all these to their original formatting, as in the English version. Also, some places we call it "állapot", other places it is "state". I don't have a rule of thumb for this, it may be ok as is, but I hope @gergely-nagy will have an opinion on this as well. Other than that, thanks for keeping up the work. |
|
@n3ko could you address the merge conflict, and remove the stylings you added that do not match with the original documentation? After that, I can happily merge this 😄! You have done a great job, would be great to see it on |
There was a problem hiding this comment.
I would also like either @gergely-nagy or @punkah to go over this for the last time, to be 100% sure. I unfortunately still managed to find some typos and inconsistencies, but it is soon ready, I am sure of it! Keep it up!
|
I found some typos, but the translation looks good! Good job @n3ko ! |
Co-Authored-By: Orsi <punkah@gmail.com> Co-Authored-By: Balázs Orbán <info@balazsorban.com> Co-Authored-By: Gergely Nagy <gergely.nagy.contact@gmail.com>
No description provided.