Translate Integrating with Other Libraries #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96 tasks
|
Deploy preview for idreactjs ready! Built with commit b3b6698 |
|
Deploy preview for id-reactjs ready! Built with commit b3b6698 |
kfnx
suggested changes
Oct 24, 2019
vferdiansyah
suggested changes
Oct 25, 2019
resir014
requested changes
Oct 25, 2019
There was a problem hiding this comment.
Silakan dicerna perubahan yang harus dilakukan sebelum kita bisa merge PR ini. Ada beberapa poin yang masih tersedia di seluruh halaman, jadi saya tidak tambahkan satu per satu sebagai "suggested change":
- Ubah penggunaan kata "kamu" menjadi "Anda"
- Perhatikan pengurutan kata benda (noun) dan kata sifat (adjective). Terkadang dalam bahasa Indonesia, pengurutannya perlu dibalik.
- Terdapat beberapa kata "itu" yang ambigu, ini sering terjadi kalau ada penerjemahan yang mentah. Kata "itu" ini merujuk kemana? Coba diberikan konteks sedikit.
vferdiansyah
suggested changes
Oct 25, 2019
…libraries.md Co-Authored-By: Kafin Salim <33047308+kafinsalim@users.noreply.github.com>
…ther-libraries.md Co-Authored-By: Kafin Salim <33047308+kafinsalim@users.noreply.github.com>
…ther-libraries.md Co-Authored-By: Kafin Salim <33047308+kafinsalim@users.noreply.github.com>
…ther-libraries.md Co-Authored-By: Kafin Salim <33047308+kafinsalim@users.noreply.github.com>
…ther-libraries.md Co-Authored-By: Kafin Salim <33047308+kafinsalim@users.noreply.github.com>
…-other-libraries.md Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
…er-libraries.md Co-Authored-By: Resi Respati <resir014@gmail.com>
…er-libraries.md Co-Authored-By: Resi Respati <resir014@gmail.com>
…-other-libraries.md Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
…ther-libraries.md Co-Authored-By: Kafin Salim <33047308+kafinsalim@users.noreply.github.com>
…ther-libraries.md Co-Authored-By: Kafin Salim <33047308+kafinsalim@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
resir014
requested changes
Oct 27, 2019
There was a problem hiding this comment.
Just finished my second pass of the review. Please address it, as well as the rest of the review notes by @vferdiansyah.
You might have missed some from the hidden parts, don't forget to click on "Load more" over here:
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
Co-Authored-By: Resi Respati <resir014@gmail.com> Co-Authored-By: Veri Ferdiansyah <vferdiansyah@users.noreply.github.com>
* Change `Kamu` to `Anda` * Change `itu` to nya * Giving more context to `itu`
|
Hi @vferdiansyah @resir014 & @kafinsalim Please review it once again, Thank you. 🙏 |
resir014
approved these changes
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please to review my work and thank you for giving me chance to contribute, here's translation for Integrating with other libraries pages to Indonesia language.