Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Implementation Notes #124

Merged
merged 22 commits into from Nov 4, 2019
Merged

Translate Implementation Notes #124

merged 22 commits into from Nov 4, 2019

Conversation

tjgeni
Copy link
Contributor

@tjgeni tjgeni commented Oct 27, 2019

No description provided.

@netlify
Copy link

netlify bot commented Oct 27, 2019

Deploy preview for idreactjs ready!

Built with commit 0043fa3

https://deploy-preview-124--idreactjs.netlify.com

@netlify
Copy link

netlify bot commented Oct 27, 2019

Deploy preview for id-reactjs ready!

Built with commit 0043fa3

https://deploy-preview-124--id-reactjs.netlify.com

Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tegarjgap! Here are my notes for the first half of the page. Will continue to read through later tonight.

content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
Tegar Jagat Geni Arya Perkasa and others added 6 commits October 31, 2019 19:57
change 'publik API' into 'API publik'

Co-Authored-By: Resi Respati <resir014@gmail.com>
remove italic symbol on path source

Co-Authored-By: Resi Respati <resir014@gmail.com>
Change subclasses into Subkelas

Co-Authored-By: Resi Respati <resir014@gmail.com>
Change ambigous text

Co-Authored-By: Resi Respati <resir014@gmail.com>
Change Element into Elemen
Change misalnya into mis.

Co-Authored-By: Resi Respati <resir014@gmail.com>
Change element into elemen

Co-Authored-By: Resi Respati <resir014@gmail.com>
Copy link
Contributor Author

@tjgeni tjgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank a lot @resir014 , I have reviewed

content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second pass. After this is done, everything should look good.

content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
Tegar Jagat Geni Arya Perkasa and others added 15 commits November 2, 2019 19:07
Change module name in React and fix capitalize

Co-Authored-By: Resi Respati <resir014@gmail.com>
Change subclasses into Subkelas

Co-Authored-By: Resi Respati <resir014@gmail.com>
Fix ambiguous text

Co-Authored-By: Resi Respati <resir014@gmail.com>
remove italic for method name in code blocks and fix the grammar

Co-Authored-By: Resi Respati <resir014@gmail.com>
remove italic for method name in code blocks

Co-Authored-By: Resi Respati <resir014@gmail.com>
remove italic in method name in code blocks

Co-Authored-By: Resi Respati <resir014@gmail.com>
remove italic for method name in code blocks

Co-Authored-By: Resi Respati <resir014@gmail.com>
change contained into dibungkus

Co-Authored-By: Resi Respati <resir014@gmail.com>
fix capitalize text

Co-Authored-By: Resi Respati <resir014@gmail.com>
add hypen on text 'dirender'

Co-Authored-By: Resi Respati <resir014@gmail.com>
add hypen on text 'dirender'

Co-Authored-By: Resi Respati <resir014@gmail.com>
add hypen on text 'dirender'

Co-Authored-By: Resi Respati <resir014@gmail.com>
add hypen on text 'dirender'

Co-Authored-By: Resi Respati <resir014@gmail.com>
don't translate text 'key'

Co-Authored-By: Resi Respati <resir014@gmail.com>
change sentence 'dari tutorial hidup ini' become 'dari tutorial ini berada'

Co-Authored-By: Resi Respati <resir014@gmail.com>
Copy link
Contributor Author

@tjgeni tjgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I already finish all review. thank a lot for correcting me @resir014 , so excited collaborating with you :)

content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your help! 🎉

@resir014 resir014 changed the title translate Implementation Notes section into Indonesian language Translate Implementation Notes Nov 4, 2019
@resir014 resir014 merged commit 310775d into reactjs:master Nov 4, 2019
@tjgeni
Copy link
Contributor Author

tjgeni commented Nov 4, 2019

Alright, Thanks @resir014

@tjgeni tjgeni deleted the Implementation-Notes branch November 4, 2019 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants