Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Hooks API Reference #127

Merged
merged 3 commits into from Dec 16, 2019
Merged

Translate Hooks API Reference #127

merged 3 commits into from Dec 16, 2019

Conversation

bangun-jds
Copy link
Contributor

Translated a Hooks API Reference page. This is not a big issue but i think worth to mention.

  • I think the word Hooks in this context refers as a name, not a verb. So it doesn't have to be italized. But in this PR i still italicized it in order to follow the style guide and based on other contributors.
  • Lastly, the introduction section on hooks has different version of translation. But it's already mentioned here. So i translated it following the proposed one by @resir014

Please kindly review my work, thanks.

@netlify
Copy link

netlify bot commented Oct 28, 2019 •
edited

Deploy preview for idreactjs ready!

Built with commit a3b7420

https://deploy-preview-127--idreactjs.netlify.com

@netlify
Copy link

netlify bot commented Oct 30, 2019 •
edited

Deploy preview for id-reactjs ready!

Built with commit a3b7420

https://deploy-preview-127--id-reactjs.netlify.com

@tesseralis tesseralis mentioned this pull request Nov 13, 2019
Closed
96 tasks
resir014
resir014 requested changes Dec 6, 2019
View reviewed changes
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor changes necessary:

content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
@bangun-jds
Copy link
Contributor Author

Updated the translation based on suggestions @resir014

@resir014 resir014 changed the title Translate hooks-reference Translate Hooks API Reference Dec 16, 2019
@resir014 resir014 merged commit 2715e98 into reactjs:master Dec 16, 2019
@bangun-jds bangun-jds deleted the tr/hooks-reference branch December 17, 2019 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@resir014 resir014 resir014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bangun-jds @resir014 @bangunbagustapa