Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Introducing JSX #13

Merged
merged 8 commits into from Feb 14, 2019
Merged

Translate Introducing JSX #13

merged 8 commits into from Feb 14, 2019

Conversation

gedeagas
Copy link
Member

Translated Introducing JSX

gedeagas
gedeagas commented Feb 11, 2019
View reviewed changes
content/docs/introducing-jsx.md Outdated

Instead of artificially separating *technologies* by putting markup and logic in separate files, React [separates *concerns*](https://en.wikipedia.org/wiki/Separation_of_concerns) with loosely coupled units called "components" that contain both. We will come back to components in a [further section](/docs/components-and-props.html), but if you're not yet comfortable putting markup in JS, [this talk](https://www.youtube.com/watch?v=x7cQ3mrcKaY) might convince you otherwise.
Alih-alih memisahkan *technologies* secara artifisial dengan meletakkan *markup* dan logika di file terpisah, React [memisahkan kepentingan *(separates concerns)*](https://en.wikipedia.org/wiki/Separation_of_concerns) dengan unit kopling rendah bernama "komponen" yang mengandung keduanya. Kita akan kembali ke komponen dalam [bagian selanjutnya](/docs/components-and-props.html), tetapi jika anda merasa belum nyaman menempatkan markup di `JavaScript`, [video ini](https://www.youtube.com/watch?v=x7cQ3mrcKaY) mungkin akan meyakinkan anda.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@regalius ini aku agak bingung di kata technologies

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kalau mau di translate sih mungkin bisa coba kata berbagai teknologi atau beberapa teknologi, tapi kalau mau tetep english sih gak masalah

@mazipan
Copy link
Collaborator

mazipan commented Feb 11, 2019

Ini kalian akan langsung PR ke master ya?
Gak bikin branch develop atau apa gitu buat full review nanti sebelum ke master?
Jadi nanti ke master nya pas udah full konten.
Mending gitflow nya disamain dulu sebelum pada mulai bikin PR.

cc: @gedeagas

@regalius
Copy link
Member

Hi @mazipan, Good idea, tapi karena translation PIC nya per-halaman jadi saya rasa belum perlu dulu untuk bikin branch develop. We're following the standard gitflow for other translation 😄 CMIIW

mazipan
mazipan reviewed Feb 11, 2019
View reviewed changes
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
@gedeagas
Copy link
Member Author

@mazipan ❤️thank you for the review mas.

untuk sekarang seperti yang mas @regalius bilang, untuk translation PIC nya masih per-halaman jadi masih ke master dulu. Dan gitflow nya kita masih ngikutin standart dari translation yang lain.

@tesseralis tesseralis mentioned this pull request Feb 11, 2019
Closed
96 tasks
regalius
regalius requested changes Feb 12, 2019
View reviewed changes
Copy link
Member

@regalius regalius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just need to change several words to meet standards and fix some wrong italicized word and we're good to go mas @gedeagas 🎉

content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
mazipan
mazipan requested changes Feb 12, 2019
View reviewed changes
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
@regalius
Copy link
Member

regalius commented Feb 12, 2019 •
edited

1 last change mas @gedeagas , Let's translate all strings & comments inside code block for consistency across pages 😄

@gedeagas
Copy link
Member Author

@regalius Updated 🎉

regalius
regalius approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@regalius regalius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gedeagas
Copy link
Member Author

Awesome 🎉

@gedeagas gedeagas merged commit 807c3a3 into reactjs:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regalius regalius regalius approved these changes

@mazipan mazipan mazipan approved these changes

@arfianadam arfianadam Awaiting requested review from arfianadam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gedeagas @mazipan @regalius