Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Virtual DOM and Internals #130

Merged
merged 4 commits into from Nov 18, 2019
Merged

Translate Virtual DOM and Internals #130

merged 4 commits into from Nov 18, 2019

Conversation

zweimach
Copy link
Contributor

Originally this part was claimed by @mekhanix, but since there was no update from the original claimer, I decided to help out. Please forgive my rudeness. And please review my translation.

@netlify
Copy link

netlify bot commented Nov 12, 2019

Deploy preview for idreactjs ready!

Built with commit 8f50cbf

https://deploy-preview-130--idreactjs.netlify.com

@netlify
Copy link

netlify bot commented Nov 12, 2019

Deploy preview for id-reactjs ready!

Built with commit 8f50cbf

https://deploy-preview-130--id-reactjs.netlify.com

@resir014
Copy link
Member

@zweimach It's okay! I was about to free up some inactive pages in the master issue tonight, but thank you for jumping the gun.

I'll update the master issue and read into your changes later tonight.

Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zweimach! There are some things to fix before merging.

content/docs/faq-internals.md Outdated Show resolved Hide resolved
content/docs/faq-internals.md Outdated Show resolved Hide resolved
content/docs/faq-internals.md Outdated Show resolved Hide resolved
content/docs/faq-internals.md Outdated Show resolved Hide resolved
content/docs/faq-internals.md Outdated Show resolved Hide resolved
content/docs/faq-internals.md Outdated Show resolved Hide resolved
@zweimach
Copy link
Contributor Author

@resir014, thank you for your feedback.

@resir014
Copy link
Member

@zweimach Thanks! I'll take a look shortly.

Oh, while you're at it, don't forget to translate the page title as well. Let's use Virtual DOM dan Internal

Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, I missed this one fix during my last review. If this was fixed this should be good to merge. Thanks!

content/docs/faq-internals.md Outdated Show resolved Hide resolved
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now. Thanks!

@resir014 resir014 merged commit 168c6d8 into reactjs:master Nov 18, 2019
@zweimach zweimach deleted the translate branch November 18, 2019 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants