Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Introducing Concurrent Mode #169

Merged
merged 2 commits into from Jun 7, 2020

Conversation

xtrixia
Copy link
Contributor

@xtrixia xtrixia commented May 21, 2020

Translated Introducing Concurrent Mode page.
Please kindly review my work.
Thanks!

@netlify
Copy link

netlify bot commented May 21, 2020

Deploy preview for id-reactjs failed.

Built with commit 7fe7a65

https://app.netlify.com/sites/id-reactjs/deploys/5ece661e1fe47c000787a16a

@netlify
Copy link

netlify bot commented May 21, 2020

Deploy preview for idreactjs ready!

Built with commit 8dc55e6

https://deploy-preview-169--idreactjs.netlify.app

Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and I support translating "concurrent mode" to "mode concurrent". There are some minor changes that I could see at the moment:

content/docs/concurrent-mode-intro.md Outdated Show resolved Hide resolved
content/docs/concurrent-mode-intro.md Outdated Show resolved Hide resolved
content/docs/concurrent-mode-intro.md Outdated Show resolved Hide resolved
@xtrixia xtrixia force-pushed the translate/concurrent-mode-intro branch from 3a47f41 to 7fe7a65 Compare May 27, 2020 13:07
@xtrixia xtrixia requested a review from resir014 May 27, 2020 13:11
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now - thanks!

@resir014
Copy link
Member

Not sure why the builds keep failing. We're merging this for now, but this might need to be looked at sometime soon.

cc: @tesseralis

@xtrixia
Copy link
Contributor Author

xtrixia commented May 30, 2020

Not sure why the builds keep failing. We're merging this for now, but this might need to be looked at sometime soon.

I was wondering about it too, was it possible because of prettier? @resir014

@resir014 resir014 merged commit 1c73cdb into reactjs:master Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants