Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translation for createContext #339

Merged
merged 5 commits into from
Apr 26, 2023
Merged

translation for createContext #339

merged 5 commits into from
Apr 26, 2023

Conversation

r17x
Copy link
Collaborator

@r17x r17x commented Apr 26, 2023 •
edited

Translation for createContext #330

@r17x r17x force-pushed the docs/translation/creatContext branch from f63c8d0 to de9049c Compare April 26, 2023 10:06
@r17x r17x marked this pull request as ready for review April 26, 2023 10:07
@r17x
Copy link
Collaborator Author

r17x commented Apr 26, 2023

Ready to review @resir014

mazipan
mazipan reviewed Apr 26, 2023
View reviewed changes
src/content/reference/react/createContext.md Outdated Show resolved Hide resolved
src/content/reference/react/createContext.md Outdated Show resolved Hide resolved
src/content/reference/react/createContext.md Outdated Show resolved Hide resolved
@r17x r17x requested a review from mazipan April 26, 2023 10:28
@mhaidarhanif
Copy link
Collaborator

mhaidarhanif commented Apr 26, 2023 •
edited

Need to confirm again whether to use context or konteks as well as context provider or penyedia konteks in the translation.

Might be decided and added to the Glossary.

cc @resir014 @r17x @mazipan @zainfathoni

@mhaidarhanif
Copy link
Collaborator

@r17x I've added some typo review comments

@resir014 resir014 mentioned this pull request Apr 26, 2023
Open
fzn0x
fzn0x reviewed Apr 26, 2023
View reviewed changes
Copy link
Contributor

@fzn0x fzn0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to comment on the following

src/content/reference/react/createContext.md Outdated Show resolved Hide resolved
@r17x r17x mentioned this pull request Apr 26, 2023
Merged
@r17x r17x mentioned this pull request Apr 26, 2023
Merged
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@r17x r17x force-pushed the docs/translation/creatContext branch from 5385f46 to d3c2524 Compare April 26, 2023 12:44
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@resir014 resir014 merged commit 0bd1bcf into reactjs:main Apr 26, 2023
4 checks passed
@mhaidarhanif
Copy link
Collaborator

@r17x @resir014 Seems there are still some typos and inconsistency though. We'll fix them on later PR then.

di dalam instead of didalam
di luar instead of diluar
Using * instead of _ for italics

samnap11 pushed a commit to samnap11/id.react.dev that referenced this pull request Apr 26, 2023
@r17x @samnap11
translation for createContext (reactjs#339)
c421faa
@resir014 resir014 mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzn0x fzn0x fzn0x left review comments

@resir014 resir014 resir014 approved these changes

@mazipan mazipan mazipan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@r17x @mhaidarhanif @resir014 @mazipan @fzn0x