Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add translation for render-and-commit #354

Merged
merged 2 commits into from Apr 29, 2023

Conversation

vhermawan
Copy link
Contributor

@vhermawan vhermawan commented Apr 27, 2023

Hello, this PR docs reference by #330, translation for render and commit section under Adding Interactivity.
Closes #447

Thank you.

@vhermawan vhermawan changed the title add translation for render-and-commit docs: add translation for render-and-commit Apr 27, 2023
@vhermawan vhermawan mentioned this pull request Apr 28, 2023
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
src/content/learn/render-and-commit.md Outdated Show resolved Hide resolved
@vhermawan
Copy link
Contributor Author

Mas @r17x I have completed the feedback, imo the word "DOM" does not need to be italicized because it is an acronym, wdyt Mas?

@mhaidarhanif
Copy link
Collaborator

mhaidarhanif commented Apr 29, 2023

Yea DOM without italic. It's like API.

Therefore in Indonesian:

  • node
  • node DOM

@vhermawan
Copy link
Contributor Author

Sure mas @mhaidarhanif, i have implemented that. I just change wording from simpul to node.

@mhaidarhanif
Copy link
Collaborator

@vhermawan Alright 👍

@github-actions
Copy link

github-actions bot commented Apr 29, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@r17x
Copy link
Collaborator

r17x commented Apr 29, 2023

Good job @mhaidarhanif @vhermawan 🚀

@r17x r17x merged commit b92c9b1 into reactjs:main Apr 29, 2023
4 checks passed
@mhaidarhanif
Copy link
Collaborator

@vhermawan Just yesterday along with @zainfathoni @resir014 @r17x we decided to use simpul to translate node, turns out it's okay. It's now in the glossary. But no worries, the maintainers will fix that later on.

@vhermawan
Copy link
Contributor Author

May i can fix it than i can create new PR mas @mhaidarhanif ?

@mhaidarhanif
Copy link
Collaborator

@vhermawan need to confirm with @resir014 @zainfathoni @r17x first whether to create a PR now or later, by @vhermawan or the maintainers

@zainfathoni
Copy link
Collaborator

If @vhermawan is available and willing to do it, we may let him create the PR @mhaidarhanif. So we can spend more time on other matters, such as reviewing the outstanding PRs. 😅

@vhermawan
Copy link
Contributor Author

Thank you mas @zainfathoni, i will create that PR for fix that. I wanna ask, for the format PR it will be same as before or not mas @zainfathoni ?

@zainfathoni
Copy link
Collaborator

Thank you mas @zainfathoni, i will create that PR for fix that. I wanna ask, for the format PR it will be same as before or not mas @zainfathoni ?

Yea, please use the same format while referencing to the same issue number. Thanks!

@vhermawan vhermawan deleted the docs/translation/render-and-commit branch May 3, 2023 13:53
@vhermawan
Copy link
Contributor Author

I just create a new PR to fix it, #538 mas @zainfathoni. Thank you for the opportunity mas-mas to contribute to translating.

r17x pushed a commit that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render and Commit
4 participants