Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: translation for input in react dom #467

Merged
merged 11 commits into from Jun 9, 2023
Merged

docs: translation for input in react dom #467

merged 11 commits into from Jun 9, 2023

Conversation

abidra
Copy link
Contributor

@abidra abidra commented Apr 28, 2023 •
edited by mhaidarhanif

Closes #423

Translation to Bahasa for Input in React Dom.

Reference: #330

@abidra abidra marked this pull request as ready for review April 30, 2023 11:41
@abidra
Copy link
Contributor Author

abidra commented May 8, 2023 •
edited

any other issues? @mhaidarhanif @r17x @resir014 @zainfathoni

@mazipan mazipan self-requested a review May 18, 2023 08:33
r17x
r17x previously requested changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@r17x r17x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All words like "render" need to be italic

src/content/reference/react-dom/components/input.md Outdated Show resolved Hide resolved
@mhaidarhanif
Copy link
Collaborator

@abidra need to resolve the requests from @r17x

@abidra
Copy link
Contributor Author

abidra commented Jun 4, 2023

render

done

@mhaidarhanif
Copy link
Collaborator

@r17x can approve so this can be merged soon

@github-actions
Copy link

github-actions bot commented Jun 4, 2023 •
edited

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@resir014 resir014 requested a review from r17x June 7, 2023 06:28
resir014
resir014 approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on re-review from @r17x

@mhaidarhanif mhaidarhanif dismissed r17x’s stale review June 8, 2023 15:34

Others already approved

@mhaidarhanif
Copy link
Collaborator

mhaidarhanif commented Jun 8, 2023 •
edited

@mazipan @resir014 All changes approved and as @r17x might be busy until 18 June so the last requested has been dismissed.

@r17x r17x force-pushed the docs/translation/react-dom-component-input branch from 0be3e7b to aecc13a Compare June 9, 2023 07:17
@r17x r17x merged commit 272ad78 into reactjs:main Jun 9, 2023
4 checks passed
FelixFern pushed a commit to FelixFern/id.react.dev that referenced this pull request Jun 13, 2023
@abidra @FelixFern
docs: translation for input in react dom (reactjs#467)
ed6ca62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazipan mazipan mazipan approved these changes

@eriansha eriansha eriansha left review comments

@FelixFern FelixFern FelixFern left review comments

@resir014 resir014 resir014 approved these changes

@r17x r17x r17x approved these changes

@zainfathoni zainfathoni Awaiting requested review from zainfathoni

@mhaidarhanif mhaidarhanif Awaiting requested review from mhaidarhanif

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<input>
7 participants
@abidra @mhaidarhanif @resir014 @mazipan @r17x @eriansha @FelixFern