Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Quick Start #500

Merged
merged 35 commits into from May 11, 2023
Merged

Translate Quick Start #500

merged 35 commits into from May 11, 2023

Conversation

mhaidarhanif
Copy link
Collaborator

@mhaidarhanif mhaidarhanif commented Apr 29, 2023

Closes #372

Description

Translate the Quick Start page.
Page URL: https://id.react.dev/learn

Progress

  • Creating and nesting components
  • Writing markup with JSX
  • Adding styles
  • Displaying data
  • Conditional rendering
  • Rendering lists
  • Responding to events
  • Updating the screen
  • Using Hooks
  • Sharing data between components
  • Next Steps

@mhaidarhanif mhaidarhanif linked an issue Apr 29, 2023 that may be closed by this pull request
11 tasks
@mhaidarhanif mhaidarhanif self-assigned this Apr 29, 2023
@github-actions
Copy link

github-actions bot commented Apr 29, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@mhaidarhanif mhaidarhanif mentioned this pull request Apr 29, 2023
11 tasks
mhaidarhanif

This comment was marked as resolved.

Copy link
Collaborator Author

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need final confirmation for styles and render words.

src/content/learn/index.md Outdated Show resolved Hide resolved
src/content/learn/index.md Show resolved Hide resolved
Copy link
Collaborator Author

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts and need confirmations.

src/content/learn/index.md Show resolved Hide resolved
src/content/learn/index.md Show resolved Hide resolved
src/content/learn/index.md Show resolved Hide resolved
Copy link
Collaborator Author

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some confirmations.

src/content/learn/index.md Outdated Show resolved Hide resolved
src/content/learn/index.md Show resolved Hide resolved
src/content/learn/index.md Show resolved Hide resolved
Copy link
Collaborator Author

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some confirmations.

src/content/learn/index.md Outdated Show resolved Hide resolved
src/content/learn/index.md Outdated Show resolved Hide resolved

<DiagramGroup>

<Diagram name="sharing_data_parent" height={385} width={410} alt="Diagram showing a tree of three components, one parent labeled MyApp and two children labeled MyButton. MyApp contains a count value of zero which is passed down to both of the MyButton components, which also show value zero." >
<Diagram name="sharing_data_parent" height={385} width={410} alt="Diagram yang menunjukkan sebuah pohon yang terdiri dari tiga komponen, satu induk (parent) berlabel MyApp dan dua anak (children) berlabel MyButton. MyApp berisi nilai hitungan nol yang diturunkan ke kedua komponen MyButton, yang juga menunjukkan nilai nol." >
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zainfathoni @resir014 @mazipan @r17x

In this context, contains a count value to berisi nilai hitungan or berisi nilai *count*?

@mhaidarhanif
Copy link
Collaborator Author

@resir014 @zainfathoni @mazipan @r17x Ready for review 🙏

Copy link
Collaborator Author

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tricky compound phrase.

src/content/learn/index.md Show resolved Hide resolved
@mhaidarhanif mhaidarhanif requested a review from mazipan May 10, 2023 10:38
src/content/learn/index.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@mazipan mazipan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good from me

src/content/learn/index.md Outdated Show resolved Hide resolved
src/content/learn/index.md Outdated Show resolved Hide resolved
@mhaidarhanif
Copy link
Collaborator Author

Need approval from @r17x for the latest changes. And maybe more approvals/requests from @zainfathoni @resir014

@r17x r17x merged commit 8b622da into main May 11, 2023
4 checks passed
@r17x
Copy link
Collaborator

r17x commented May 11, 2023

Ship it @mhaidarhanif @mazipan 🚀


## Using Hooks {/*using-hooks*/}
## Mengggunakan Hooks {/*using-hooks*/}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@r17x @mazipan there's a typo, Mengggunakan 🤣

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a new PR to solve the typo: #561

cc @zainfathoni @resir014

FelixFern pushed a commit to FelixFern/id.react.dev that referenced this pull request Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quick Start
5 participants