Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate State as a Snapshot page to Indonesia #513

Merged
merged 11 commits into from May 6, 2023

Conversation

lionelritchie29
Copy link
Contributor

Closes #448

Description

Translate the State as a Snapshot page.
Page URL: https://id.react.dev/learn/state-as-a-snapshot

@github-actions
Copy link

github-actions bot commented May 1, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mhaidarhanif

This comment was marked as outdated.

Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine but let's wait for the others. @resir014 @mazipan @zainfathoni

src/content/learn/state-as-a-snapshot.md Outdated Show resolved Hide resolved
src/content/learn/state-as-a-snapshot.md Outdated Show resolved Hide resolved
src/content/learn/state-as-a-snapshot.md Outdated Show resolved Hide resolved
resir014 and others added 2 commits May 4, 2023 11:25
Co-authored-by: Irfan Maulana <mazipanneh@gmail.com>
Co-authored-by: Irfan Maulana <mazipanneh@gmail.com>
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes requested. @lionelritchie29

src/content/learn/state-as-a-snapshot.md Outdated Show resolved Hide resolved
@lionelritchie29
Copy link
Contributor Author

Some changes requested. @lionelritchie29

I think it is okay to change it to that. Should I commit the suggestion or it must be done by the maintainer? @resir014

@mazipan
Copy link
Collaborator

mazipan commented May 4, 2023

You fix it by yourself, then we will re-review after your fixes.

@lionelritchie29
Copy link
Contributor Author

You fix it by yourself, then we will re-review after your fixes.

I've updated the content as suggested.

Thank you.

@r17x r17x merged commit 052ecee into reactjs:main May 6, 2023
4 checks passed
r17x pushed a commit that referenced this pull request May 8, 2023
Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>
Co-authored-by: Resi Respati <resir014@gmail.com>
Co-authored-by: Irfan Maulana <mazipanneh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

State as a Snapshot
5 participants