Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Code-Splitting #52

Merged
merged 9 commits into from Aug 12, 2019
Merged

Conversation

masbagal
Copy link
Contributor

@masbagal masbagal commented Mar 4, 2019

Thanks for the opportunity.

BTW, I cannot find the nice translation for code-splitting so I leave it as it is. I've tried pemecahan kode and pembagian kode but it didn't felt right. Finally left it as code-splitting also thinking that should someone wants to dive deeper, using the term code-splitting as a search keyword will make the search easier.

Please comment if you have suggestion 🙇‍♂️

@netlify
Copy link

netlify bot commented Mar 4, 2019

Deploy preview for id-reactjs ready!

Built with commit 57ca46f

https://deploy-preview-52--id-reactjs.netlify.com

@masbagal masbagal changed the title Translating Code-Splitting page Translating Advanced-Guides/Code-Splitting page Mar 4, 2019
@reactjs reactjs deleted a comment from netlify bot Mar 5, 2019
@reactjs reactjs deleted a comment from netlify bot Mar 5, 2019
@reactjs reactjs deleted a comment from netlify bot Mar 5, 2019
@grikomsn grikomsn changed the title Translating Advanced-Guides/Code-Splitting page Translate Code-Splitting Jul 13, 2019
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hai, ada beberapa hal yang harus diubah sebelum di-merge. Please take a look.

content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Outdated Show resolved Hide resolved
content/docs/code-splitting.md Show resolved Hide resolved
@masbagal
Copy link
Contributor Author

masbagal commented Aug 6, 2019

Terimakasih untuk reviewnya.
Updated, minta tolong bantuannya untuk dicek ulang @resir014

Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @masbagal ❤️

@resir014 resir014 merged commit 76376e1 into reactjs:master Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants