Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: translate Managing State #539

Merged
merged 12 commits into from Jun 27, 2023

Conversation

andriansanto
Copy link
Contributor

@github-actions
Copy link

github-actions bot commented May 3, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Collaborator

@zainfathoni zainfathoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing, @andriansanto! 🙏
Though I have a few comments that might lead to significant changes.
So please address them first, and then I will give it another review once you addressed them all. 😁

src/content/learn/managing-state.md Outdated Show resolved Hide resolved
src/content/learn/managing-state.md Outdated Show resolved Hide resolved
src/content/learn/managing-state.md Outdated Show resolved Hide resolved
@andriansanto
Copy link
Contributor Author

Thanks for contributing, @andriansanto! 🙏 Though I have a few comments that might lead to significant changes. So please address them first, and then I will give it another review once you addressed them all. 😁

Thankyou for the feedback, will solve it soon 😄

@andriansanto
Copy link
Contributor Author

Thanks for contributing, @andriansanto! 🙏 Though I have a few comments that might lead to significant changes. So please address them first, and then I will give it another review once you addressed them all. 😁

Thankyou for the feedback, will solve it soon 😄

Done, Kindly for the review again @zainfathoni 🙏

Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to translate the page title as well.

---
title: Mengelola State
---

@resir014 resir014 requested a review from zainfathoni May 4, 2023 04:15
Co-authored-by: Zain Fathoni <zain.fathoni@gmail.com>
@mhaidarhanif
Copy link
Collaborator

@resir014 and @zainfathoni can check and approve if okay.

@huedaya
Copy link
Contributor

huedaya commented Jun 13, 2023

Rewrite just a bit to make it more natural andriansanto#1

Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to go with @huedaya's additions. Will cherry-pick and merge when I have the time.

@resir014 resir014 dismissed zainfathoni’s stale review June 26, 2023 10:11

Changes implemented and co-approved.

@resir014 resir014 changed the title docs translation managing state docs: translate Managing State Jun 26, 2023
Co-authored-by: Khakim Hudaya <hamas182@gmail.com>
@resir014 resir014 merged commit 5a22845 into reactjs:main Jun 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Managing State
7 participants