Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: translate Extracting State Logic into a Reducer #544

Merged
merged 15 commits into from Jul 17, 2023
Merged

docs: translate Extracting State Logic into a Reducer #544

merged 15 commits into from Jul 17, 2023

Conversation

thaddeuscleo
Copy link
Contributor

Closes: #383

@thaddeuscleo thaddeuscleo marked this pull request as ready for review May 8, 2023 06:44
@thaddeuscleo thaddeuscleo changed the title docs: Indonesia translation for page Updating Objects in State docs: Indonesia translation for Extracting State Logic into a Reducer May 8, 2023
@thaddeuscleo thaddeuscleo marked this pull request as draft May 8, 2023 06:46
@thaddeuscleo thaddeuscleo marked this pull request as ready for review May 8, 2023 12:00
mhaidarhanif
mhaidarhanif previously requested changes May 10, 2023
View reviewed changes
Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some changes.

src/content/learn/extracting-state-logic-into-a-reducer.md Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented May 10, 2023 •
edited

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@resir014
Copy link
Member

Hi @thaddeuscleo, has the requested changes been made?

@resir014
Copy link
Member

Taking over this PR since it's been weeks without any additional response.

@resir014 @mhaidarhanif
docs: apply suggestions from code review
cc7a548 
Co-authored-by: M Haidar Hanif <git@mhaidarhanif.com>
@resir014 resir014 changed the title docs: Indonesia translation for Extracting State Logic into a Reducer docs: translate Extracting State Logic into a Reducer Jun 29, 2023
resir014
resir014 reviewed Jul 12, 2023
View reviewed changes
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more requested changes to use the correct form of "di-" @thaddeuscleo

src/content/learn/extracting-state-logic-into-a-reducer.md Outdated Show resolved Hide resolved
src/content/learn/extracting-state-logic-into-a-reducer.md Outdated Show resolved Hide resolved
@resir014
Copy link
Member

@thaddeuscleo Could you make the requested changes within the next 2 days? If not, the maintainers can take over this PR.

@mhaidarhanif mhaidarhanif dismissed their stale review July 16, 2023 13:27

Continue with the others

@resir014 resir014 merged commit 3ea3506 into reactjs:main Jul 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@resir014 resir014 resir014 approved these changes

@mazipan mazipan mazipan left review comments

@r17x r17x r17x approved these changes

@zainfathoni zainfathoni Awaiting requested review from zainfathoni

@mhaidarhanif mhaidarhanif Awaiting requested review from mhaidarhanif

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extracting State Logic into a Reducer
5 participants
@thaddeuscleo @resir014 @mhaidarhanif @mazipan @r17x