Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Accessibility #58

Merged
merged 2 commits into from Jul 10, 2019
Merged

Translate Accessibility #58

merged 2 commits into from Jul 10, 2019

Conversation

ekafyi
Copy link
Contributor

@ekafyi ekafyi commented Mar 7, 2019

Hi, here’s my PR. Some notes:

  • I used a flexible translation approach (eg. altering sentence structure to one that sounds more natural in Indonesian) without changing the meaning.
  • My references are, in order of priority: this repo’s “Glosarium”, other accepted PRs, KBBI, large/established sources (eg. Google & Firefox’s Indonesian webites), search results.

I listed specific recurrent words & phrases and my translation strategies in this gist; might be useful for you to review and advise accordingly.

Thanks!

@netlify
Copy link

netlify bot commented Mar 7, 2019

Deploy preview for idreactjs ready!

Built with commit 849f4c5

https://deploy-preview-58--idreactjs.netlify.com

@netlify
Copy link

netlify bot commented Mar 7, 2019

Deploy preview for id-reactjs ready!

Built with commit 849f4c5

https://deploy-preview-58--id-reactjs.netlify.com

index.mdx Outdated Show resolved Hide resolved
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ekafyi! Please undo the yarn.lock deletion before I can merge, as it is required.

@grikomsn
Copy link
Member

grikomsn commented Jul 8, 2019

Since the yarn.lock and other unrelated files are commited long time ago, I recommend submitting another pull request or force-pushing the branch.

Update: I have made a draft pull request (#89) for the Accessibility page translation, if needed.

@grikomsn grikomsn changed the title Accessibility Translate Accessibility Jul 8, 2019
@ekafyi
Copy link
Contributor Author

ekafyi commented Jul 8, 2019

Hi @resir014 @grikomsn,
Shall I add yarn.lock back to this branch regardless or is #89 sufficient?

@grikomsn
Copy link
Member

grikomsn commented Jul 8, 2019

IMO, in order to resolve the conflicts, initiate a soft git reset to commit df09630, then re-commit the "Accessibility" translation progress like what I did on #89.

Or you can improve the translation on #89 (which I have given @ekafyi and @resir014 permission to commit) and close this PR.

@ekafyi
Copy link
Contributor Author

ekafyi commented Jul 9, 2019

IMO, in order to resolve the conflicts, initiate a soft git reset to commit df09630, then re-commit the "Accessibility" translation progress like what I did on #89.

Hi @grikomsn, I've done this solution (git reset then recommit). Please kindly check.

Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ekafyi! Much appreciated.

@resir014 resir014 merged commit 3875773 into reactjs:master Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants