Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate state and lifecycle to Bahasa #61

Merged
merged 3 commits into from Jul 4, 2019

Conversation

amiruddinid
Copy link
Contributor

I have been done translating this section, please kindly review

I keep some of word in english that maybe reference to React function or method
like "Mount" & "Unmounting" for componentWillMount() & componentWillUnmount() lifecycle methods

@netlify
Copy link

netlify bot commented Mar 19, 2019

Deploy preview for id-reactjs ready!

Built with commit 7c2daa5

https://deploy-preview-61--id-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Mar 19, 2019

Deploy preview for idreactjs ready!

Built with commit 7c2daa5

https://deploy-preview-61--idreactjs.netlify.com

@gedeagas
Copy link
Member

Awesome, thank you for contributing. I will check your work tommorow

Copy link
Collaborator

@rizafahmi rizafahmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amiruddinid ada beberapa perubahan minor yang harus diperbaiki. Setelah itu aman! Terimakasih!!

content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
@amiruddinid
Copy link
Contributor Author

The requested modifications have been completed., please kindly check @rizafahmi @gedeagas,
thank you

@rizafahmi
Copy link
Collaborator

All good. Well done @amiruddinid. It's all yours @gedeagas !!

@resir014 resir014 merged commit 7768199 into reactjs:master Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants