Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate "Thinking in React" #8

Merged
merged 6 commits into from Feb 14, 2019
Merged

Translate "Thinking in React" #8

merged 6 commits into from Feb 14, 2019

Conversation

resir014
Copy link
Member

@resir014 resir014 commented Feb 10, 2019

This is the translated version of Thinking in React. I took some of the translations already available on the Crowdin, with some changes to follow the style guide. I'm going to add some personal notes for the reviewers to look at.

content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
@resir014
Copy link
Member Author

First pass of code review done, mas.

Copy link
Member

@regalius regalius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll only need to adjust several italicized words and common terms regarding to the glossary and we're good to go.. Thanks mas @resir014 !

content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
@resir014
Copy link
Member Author

@regalius Okay, done mas.

Copy link
Member

@gedeagas gedeagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @resir014 🎉. Thank you for contributing

@gedeagas gedeagas merged commit ef53970 into reactjs:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants