Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Conditional Rendering #92

Merged
merged 3 commits into from
Oct 26, 2019

Conversation

andriawan
Copy link
Contributor

Dear Maintainers, i propose PR in Translating Conditional Rendering. Please review this work and give me feedback. Thank you for giving me chance to join this project.

@netlify
Copy link

netlify bot commented Jul 14, 2019

Deploy preview for idreactjs ready!

Built with commit 5d50927

https://deploy-preview-92--idreactjs.netlify.com

@netlify
Copy link

netlify bot commented Jul 14, 2019

Deploy preview for id-reactjs ready!

Built with commit c6bab94

https://deploy-preview-92--id-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Jul 14, 2019

Deploy preview for id-reactjs ready!

Built with commit 5d50927

https://deploy-preview-92--id-reactjs.netlify.com

@grikomsn grikomsn self-assigned this Jul 15, 2019
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ada beberapa poin sedikit yang perlu di-addres sebelum PR ini dapat di-merge. Thanks sebelumnya!

content/docs/conditional-rendering.md Show resolved Hide resolved
content/docs/conditional-rendering.md Show resolved Hide resolved
content/docs/conditional-rendering.md Show resolved Hide resolved
content/docs/conditional-rendering.md Show resolved Hide resolved
Copy link
Member

@grikomsn grikomsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most are minor typos which can be commited using the suggestion, but some must be discussed further related to usage of merender or dirender and other phrasings.

content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
@grikomsn
Copy link
Member

Hello there, @andriawan. Please check the discussion and commit suggestions, since others cannot make changes to your branch unless you allow edits from maintainers. Thanks in advance. 😄

@andriawan
Copy link
Contributor Author

Sorry for pending response for the feedback. Anyway, thanks for giving me the feedback. i will propose commit with suggestions. Could you give me clue in allowing edits my branch @grikomsn ?

Hello there, @andriawan. Please check the discussion and commit suggestions, since others cannot make changes to your branch unless you allow edits from maintainers. Thanks in advance. 😄

@grikomsn
Copy link
Member

Open this PR, look below the "Lock conversation" and there should be a checkbox to allow edits from maintainers. Check that and other maintainers can edit too for quicker revisions. 😄

image

@andriawan
Copy link
Contributor Author

test

i think it has already done...

@grikomsn
Copy link
Member

Yet somehow I cannot apply commit suggestions. Looks like you should apply revisions yourself for now. 😅

image

@resir014, any ideas about this?

@andriawan
Copy link
Contributor Author

Dear maintainers, could I have some feedback? @grikomsn

@andriawan
Copy link
Contributor Author

does it need any further improvement? @grikomsn

@resir014 resir014 assigned resir014 and unassigned grikomsn Oct 23, 2019
@resir014 resir014 merged commit 444a55d into reactjs:master Oct 26, 2019
@andriawan andriawan deleted the conditional-rendering branch February 10, 2020 08:19
@resir014 resir014 mentioned this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants