Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated Keeping components pure #430

Merged
merged 41 commits into from May 8, 2023

Conversation

Ago95Dev
Copy link
Contributor

Italian translation for "Keeping components pure" page and sidebar entry.

Alcuni termini come:
Side Effects
Story Tray
Ho preferito non tradurli, ma non so, vorrei qualche parere.

Part of #418

Ago95Dev and others added 4 commits April 28, 2023 15:51
Traduzione iniziale da riga 1 a 240
Italian translation "keeping-components-pure" and Sidebar entry. Righe 1 a 862.
@Ago95Dev Ago95Dev changed the title Keeping components pure Translated Keeping components pure Apr 29, 2023
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.47 KB (🟡 +2 B) 170.1 KB
/500 76.47 KB (🟡 +2 B) 170.1 KB
/[[...markdownPath]] 77.89 KB (🟡 +2 B) 171.52 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.47 KB (🟡 +2 B) 170.1 KB
/500 76.47 KB (🟡 +2 B) 170.1 KB
/[[...markdownPath]] 77.89 KB (🟡 +2 B) 171.52 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.47 KB (🟡 +2 B) 170.1 KB
/500 76.47 KB (🟡 +2 B) 170.1 KB
/[[...markdownPath]] 77.89 KB (🟡 +2 B) 171.52 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Contributor

@Th3Wall Th3Wall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ciao @Ago95Dev 😄

Mi sono permesso di fare la review della tua PR e ti ho lasciato alcuni suggerimenti: la maggior parte di questi riguardano la sintassi

src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
src/content/learn/keeping-components-pure.md Outdated Show resolved Hide resolved
Ago95Dev and others added 3 commits May 2, 2023 16:09
Co-authored-by: Davide Mandelli <mandellidavide.95@gmail.com>
Co-authored-by: Davide Mandelli <mandellidavide.95@gmail.com>
Co-authored-by: Davide Mandelli <mandellidavide.95@gmail.com>
Co-authored-by: Davide Mandelli <mandellidavide.95@gmail.com>
@github-actions
Copy link

github-actions bot commented May 2, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.5 KB (🟡 +2 B) 170.12 KB
/500 76.49 KB (🟡 +2 B) 170.12 KB
/[[...markdownPath]] 77.92 KB (🟡 +2 B) 171.54 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Ago95Dev and others added 2 commits May 2, 2023 16:13
Co-authored-by: Davide Mandelli <mandellidavide.95@gmail.com>
Co-authored-by: Davide Mandelli <mandellidavide.95@gmail.com>
Co-authored-by: Davide Mandelli <mandellidavide.95@gmail.com>
Co-authored-by: Davide Mandelli <mandellidavide.95@gmail.com>
Ago95Dev and others added 2 commits May 2, 2023 16:26
Co-authored-by: Davide Mandelli <mandellidavide.95@gmail.com>
Co-authored-by: Davide Mandelli <mandellidavide.95@gmail.com>
Copy link
Collaborator

@mattia-sanfilippo mattia-sanfilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ciao @Ago95Dev! Grazie mille 🚀
Ho proposto qualche piccola correzione, in particolare per quanto riguarda il case all'interno dei titoli. Di norma lasciamo il case in base alla versione originale.

Ottimo lavoro 💯

Ago95Dev and others added 2 commits May 3, 2023 11:11
Co-authored-by: Mattia Sanfilippo <me@mattiasanfilippo.dev>
Co-authored-by: Mattia Sanfilippo <me@mattiasanfilippo.dev>
Co-authored-by: Mattia Sanfilippo <me@mattiasanfilippo.dev>
Ago95Dev and others added 9 commits May 3, 2023 11:14
Co-authored-by: Mattia Sanfilippo <me@mattiasanfilippo.dev>
Co-authored-by: Mattia Sanfilippo <me@mattiasanfilippo.dev>
Co-authored-by: Mattia Sanfilippo <me@mattiasanfilippo.dev>
Co-authored-by: Mattia Sanfilippo <me@mattiasanfilippo.dev>
Co-authored-by: Mattia Sanfilippo <me@mattiasanfilippo.dev>
Co-authored-by: Mattia Sanfilippo <me@mattiasanfilippo.dev>
Co-authored-by: Mattia Sanfilippo <me@mattiasanfilippo.dev>
Co-authored-by: Mattia Sanfilippo <me@mattiasanfilippo.dev>
Co-authored-by: Mattia Sanfilippo <me@mattiasanfilippo.dev>
Copy link
Collaborator

@mattia-sanfilippo mattia-sanfilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie per le modifiche! :) 🚀

@deblasis deblasis merged commit 1f4e7a1 into reactjs:main May 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants