Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with react.dev @ da93812c #441

Merged
merged 12 commits into from
May 8, 2023
Merged

Sync with react.dev @ da93812c #441

merged 12 commits into from
May 8, 2023

Conversation

react-translations-bot
Copy link
Collaborator

This PR was automatically generated.

Merge changes from react.dev at da93812

DO NOT SQUASH MERGE THIS PULL REQUEST!

Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.

acdlite and others added 12 commits May 3, 2023 20:40
This reverts commit aa88d8a.
* Revert "Revert "Canaries blog post""

This reverts commit 9a865fd.

* words

---------

Co-authored-by: Sophie Alpert <git@sophiebits.com>
…(#6003)

Mounting with Suspense and Offscreen can happen multiple times. This removes some wording that implies a that effects / lifecycle hooks only happen on first mount.
Otherwise the address is being offset to the right when the refresh icon is not displayed
@github-actions
Copy link

github-actions bot commented May 8, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.57 KB (🟡 +77 B) 170.2 KB
/500 76.56 KB (🟡 +77 B) 170.19 KB
/[[...markdownPath]] 77.99 KB (🟡 +77 B) 171.62 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@deblasis deblasis merged commit 9d222f8 into main May 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet