Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate File Structure #120

Merged
merged 5 commits into from Feb 13, 2019
Merged

Translate File Structure #120

merged 5 commits into from Feb 13, 2019

Conversation

syug
Copy link
Contributor

@syug syug commented Feb 13, 2019

This PR is a part of #4, based on the Crowdin translation here.
Review it please 🙏

@syug syug changed the title Tr/faq structure Translate File Structure Feb 13, 2019
@smikitky smikitky self-requested a review February 13, 2019 11:46
@smikitky smikitky added the 🚫 in intial review 初期レビューの真っ最中 label Feb 13, 2019
smikitky
smikitky requested changes Feb 13, 2019
View reviewed changes
Copy link
Member

@smikitky smikitky left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認しました。文章自体は問題なさそうでしたので、一部スペースのスタイルに関する指摘のみです。

全体的なことですが、文ごとに改行せずにオリジナルの原文の行を保ってください。差分で見たときに行番号が完全に左右で一致しているのが理想です。理由として、「改行部分は余計な半角スペースとして表示される」ということと、「将来原文に更新が入ったときに、見た目をできるだけ近づけておくとGit側で正しく対応付けてくれる可能性が上がる（はず）」ということがあります。

content/docs/faq-structure.md Outdated Show resolved Hide resolved
content/docs/faq-structure.md Outdated Show resolved Hide resolved
@smikitky smikitky removed the 🚫 in intial review 初期レビューの真っ最中 label Feb 13, 2019
@tesseralis tesseralis mentioned this pull request Feb 13, 2019
Closed
90 tasks
@syug
Copy link
Contributor Author

syug commented Feb 13, 2019

@smikitky 修正反映しました！ご確認よろしくお願いします。

@smikitky
Copy link
Member

確認しました、ありがとうございました！

@koba04 koba04 merged commit d97c593 into reactjs:master Feb 13, 2019
@koba04
Copy link
Member

koba04 commented Feb 13, 2019

@syug mergeしました 🎉🎉 ありがとうございます！！ 🚀🚀🚀

@syug
Copy link
Contributor Author

syug commented Feb 13, 2019

良かったです、ありがとうございます！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koba04 koba04 koba04 approved these changes

@smikitky smikitky smikitky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@syug @smikitky @koba04