Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR request with no-response #94

Closed
gnujoow opened this issue Apr 11, 2019 · 12 comments
Closed

PR request with no-response #94

gnujoow opened this issue Apr 11, 2019 · 12 comments

Comments

@gnujoow
Copy link
Member

gnujoow commented Apr 11, 2019

there are some PR requests with a month long no response from PR author.

For effective project progress and participation of other participants, I suggest to make rule dealing with un-managed reviewed pull requests.

@reactjs/reactjs-org-korean-translation

@hg-pyun
Copy link
Member

hg-pyun commented Apr 12, 2019

If we don't get an answer, how do you transfer it to someone else?

@taehwanno
Copy link
Member

It's time to decide how to assign other people about no response pull request for a long time.

if we assign them to other translators, the translator that is not a maintainer needs to fork the pull request author's repository and submits a new pull request.
(e.g. need to fork taehwanno/ko.reactjs.org. not a reactjs/ko.reactjs.org)

I think it's better to maintain review threads in the already submitted pull request. So, how about one of the maintainers do the translation on behalf of pull request author with no response pull request over 3~4 weeks? the period can be changed.

@simsim0709
Copy link
Collaborator

I agree with @taehwanno. We may have another label for that something like no-response. Then, we can continue on the unfinished translation.

@taehwanno
Copy link
Member

I will first try this decision starting at #18

@simsim0709
Copy link
Collaborator

I'll try #76

@simsim0709
Copy link
Collaborator

#76 is done.

I'll try #46

@taehwanno
Copy link
Member

I added no long-term response label for no response pull request over 2 weeks.

@simsim0709
Copy link
Collaborator

#46 done.

I'll try #47

@taehwanno
Copy link
Member

I will try #109

@gnujoow
Copy link
Member Author

gnujoow commented Nov 19, 2019

@taehwanno
Copy link
Member

taehwanno commented Nov 19, 2019

I will try #121.

Updated: done :)

@taehwanno
Copy link
Member

Because many pages have been already translated, I will close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants