Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Accessibility #46

Merged
merged 7 commits into from May 23, 2019
Merged

Translate Accessibility #46

merged 7 commits into from May 23, 2019

Conversation

hiddenest
Copy link
Contributor

@hiddenest hiddenest commented Feb 22, 2019 •
edited by simsim0709

Progress

@hiddenest hiddenest mentioned this pull request Feb 22, 2019
Closed
98 tasks
@netlify
Copy link

netlify bot commented Feb 22, 2019 •
edited

Deploy preview for ko-reactjs-org ready!

Built with commit 3e4dca9

https://deploy-preview-46--ko-reactjs-org.netlify.com

@taehwanno
Copy link
Member

upstream과 sync되면서 master 브랜치의 모든 링크 주소가 https로 변경 및 최신화되어 직접 충돌 해결했습니다.

taggon
taggon reviewed Feb 26, 2019
View reviewed changes
content/docs/accessibility.md Outdated Show resolved Hide resolved
content/docs/accessibility.md Outdated Show resolved Hide resolved
content/docs/accessibility.md Outdated Show resolved Hide resolved
content/docs/accessibility.md Outdated Show resolved Hide resolved
@hiddenest
Copy link
Contributor Author

@taggon 말씀해주신 리뷰 사항 모두 반영하였습니다. 읽어주셔서 감사합니다 👍👍👍
혹시 또 문제가 있다면 바로 알려주세요 :)

@taehwanno taehwanno added needs review Needs review A pull request ready to be reviewed needs +1 approval and removed needs review Needs review A pull request ready to be reviewed labels Feb 28, 2019
taggon
taggon reviewed Mar 14, 2019
View reviewed changes
content/docs/accessibility.md Show resolved Hide resolved
content/docs/accessibility.md Outdated Show resolved Hide resolved
content/docs/accessibility.md Outdated Show resolved Hide resolved
content/docs/accessibility.md Outdated Show resolved Hide resolved
content/docs/accessibility.md Outdated Show resolved Hide resolved
content/docs/accessibility.md Outdated Show resolved Hide resolved
content/docs/accessibility.md Outdated Show resolved Hide resolved
content/docs/accessibility.md Outdated Show resolved Hide resolved
content/docs/accessibility.md Outdated Show resolved Hide resolved
content/docs/accessibility.md Outdated Show resolved Hide resolved
hg-pyun
hg-pyun reviewed Mar 27, 2019
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hiddenest
수정되면 말씀해주세요!

taehwanno
taehwanno reviewed Mar 31, 2019
View reviewed changes
content/docs/accessibility.md Outdated Show resolved Hide resolved
content/docs/accessibility.md Outdated Show resolved Hide resolved
@taehwanno taehwanno added needs author response Changes requested needing author's input and removed needs +1 approval labels Mar 31, 2019
@simsim0709 simsim0709 mentioned this pull request May 23, 2019
Closed
@simsim0709 simsim0709 self-requested a review May 23, 2019 08:07
simsim0709
simsim0709 approved these changes May 23, 2019
View reviewed changes
Copy link
Collaborator

@simsim0709 simsim0709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 많으셨습니다~ 👍

@simsim0709 simsim0709 requested review from hg-pyun and taehwanno and removed request for hg-pyun May 23, 2019 08:12
@simsim0709 simsim0709 added needs +1 approval and removed needs author response Changes requested needing author's input labels May 23, 2019
hg-pyun
hg-pyun approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hg-pyun hg-pyun added ready to merge push the merge button :) and removed needs +1 approval labels May 23, 2019
@hg-pyun hg-pyun merged commit 96c1d3f into reactjs:master May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taggon taggon taggon left review comments

@simsim0709 simsim0709 simsim0709 approved these changes

@hg-pyun hg-pyun hg-pyun approved these changes

@taehwanno taehwanno Awaiting requested review from taehwanno

Assignees
No one assigned
Labels
ready to merge push the merge button :)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hiddenest @taehwanno @taggon @simsim0709 @hg-pyun