Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translated Add React to a Website. #101

Merged
merged 8 commits into from May 22, 2019
Merged

Translated Add React to a Website. #101

merged 8 commits into from May 22, 2019

Conversation

ymin1103
Copy link
Contributor

@ymin1103 ymin1103 commented Apr 21, 2019 •
edited

Add React to a Website 부분 번역의 초안입니다.

개인 사정으로 번역이 늦어진 점 대단히 죄송합니다.

Progress

@netlify
Copy link

netlify bot commented Apr 21, 2019 •
edited

Deploy preview for ko-reactjs-org ready!

Built with commit 7facb10

https://deploy-preview-101--ko-reactjs-org.netlify.com

@taehwanno
Copy link
Member

괜찮습니다 😄체크리스트에 모범사례 확인부터 시작해서 완료되지 않은 리스트 확인하시고 체크 부탁드려요.
추가적으로 충돌 해결 부탁드립니다!

@tesseralis tesseralis mentioned this pull request Apr 22, 2019
Closed
98 tasks
@taehwanno taehwanno added the needs review Needs review A pull request ready to be reviewed label Apr 22, 2019
@taehwanno taehwanno mentioned this pull request Apr 22, 2019
Closed
6 tasks
@taehwanno
Copy link
Member

충돌을 직접 해결했습니다.

@simsim0709 simsim0709 added needs author response Changes requested needing author's input and removed needs review Needs review A pull request ready to be reviewed labels May 20, 2019
@hg-pyun hg-pyun removed the needs author response Changes requested needing author's input label May 21, 2019
@hg-pyun hg-pyun added needs +1 approval ready to merge push the merge button :) labels May 21, 2019
hg-pyun
hg-pyun approved these changes May 21, 2019
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다. 한분 더 Approve 부탁드립니다.

@simsim0709 simsim0709 self-requested a review May 22, 2019 03:55
simsim0709
simsim0709 approved these changes May 22, 2019
View reviewed changes
Copy link
Collaborator

@simsim0709 simsim0709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~ 👍

@simsim0709 simsim0709 merged commit f204929 into reactjs:master May 22, 2019
@ymin1103 ymin1103 deleted the add-a-react-to-a-website branch May 22, 2019 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simsim0709 simsim0709 simsim0709 approved these changes

@hg-pyun hg-pyun hg-pyun approved these changes

Assignees
No one assigned
Labels
ready to merge push the merge button :)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ymin1103 @taehwanno @simsim0709 @hg-pyun