Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Implementation-notes.md #129

Merged
merged 8 commits into from Mar 7, 2020

Conversation

baekjuwon
Copy link
Contributor

@netlify
Copy link

netlify bot commented May 26, 2019

Deploy preview for ko-reactjs-org ready!

Built with commit f61e526

https://deploy-preview-129--ko-reactjs-org.netlify.com

@taehwanno taehwanno added the needs review Needs review A pull request ready to be reviewed label May 26, 2019
@tesseralis tesseralis mentioned this pull request May 26, 2019
98 tasks
Copy link
Member

@gnujoow gnujoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전체적으로 번역투의 문장이 많이 사용된것 같습니다.

content/docs/implementation-notes.md Outdated Show resolved Hide resolved
Copy link
Member

@taehwanno taehwanno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

세부적인 기술 내용이 많아서 리뷰에 시간이 많이 드네요 😢 피드백 드려요 ㅎㅎ

content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
Copy link
Member

@taehwanno taehwanno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

세부적인 기술 내용이 많아서 리뷰에 시간이 많이 드네요 😢 피드백 드려요 ㅎㅎ

content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
@taehwanno taehwanno added needs author response Changes requested needing author's input and removed needs review Needs review A pull request ready to be reviewed labels Nov 5, 2019
@taehwanno
Copy link
Member

제가 직접 수정해서 푸쉬할게요!

Copy link
Member

@taehwanno taehwanno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드의 영어 주석 번역이 필요한데 일단 반영하고 다른 PR에서 추가 번역하는 방향으로 가겠습니다. 고생하셨습니다!

@taehwanno taehwanno merged commit b776c3c into reactjs:master Mar 7, 2020
@taehwanno taehwanno removed the needs author response Changes requested needing author's input label Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants