Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate JSX In Depth #177

Merged
merged 11 commits into from Mar 13, 2020
Merged

Translate JSX In Depth #177

merged 11 commits into from Mar 13, 2020

Conversation

hIkipooh
Copy link
Contributor

@hIkipooh hIkipooh commented Oct 22, 2019

최초 피드백 사항이였던 다른 파일에 대한 불필요 커밋 제거 후 다시 pull request 요청합니다 ㅠ
주니어로 일 시작하고 정말 정신이 없어서 너무 오래 걸려서 죄송합니다 ㅠㅠ

Progress

@netlify
Copy link

netlify bot commented Oct 22, 2019

Deploy preview for ko-reactjs-org ready!

Built with commit ae0a6b0

https://deploy-preview-177--ko-reactjs-org.netlify.com

@taehwanno
Copy link
Member

괜찮습니다 ㅎㅎ Progress에 마크다운 문법에 맞게 체크박스를 만들어놨어요. 각 단계별로 확인하시고 완료하셨다면 체크 부탁드릴게요.

@taehwanno taehwanno mentioned this pull request Oct 28, 2019
6 tasks
@taehwanno taehwanno added the needs author response Changes requested needing author's input label Oct 28, 2019
@taehwanno taehwanno changed the title Fixed mixed commit other than JSX in Depth Translate JSX In Depth Oct 30, 2019
content/docs/jsx-in-depth.md Show resolved Hide resolved
content/docs/jsx-in-depth.md Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
@hIkipooh
Copy link
Contributor Author

체크사항 및 피드백 사항 반영하여 다시 pull request 드립니다~!

@taehwanno taehwanno added needs +1 approval and removed needs author response Changes requested needing author's input labels Nov 30, 2019
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
taehwanno
taehwanno previously approved these changes Nov 30, 2019
Copy link
Member

@taehwanno taehwanno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

몇 가지 직접 수정했습니다. 고생하셨습니다.

Copy link
Member

@gnujoow gnujoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

원문과 행이 맞지 않습니다. 포멧을 맞추기 위해 수정해주시면 감사하겠습니다.

content/docs/jsx-in-depth.md Show resolved Hide resolved
@hg-pyun hg-pyun self-requested a review March 13, 2020 06:57
@hg-pyun hg-pyun added ready to merge push the merge button :) and removed needs +1 approval labels Mar 13, 2020
@hg-pyun
Copy link
Member

hg-pyun commented Mar 13, 2020

오래 기다리셨습니다. 더 이상 문제가 없다면 병합하도록 하겠습니다 :)

@hg-pyun hg-pyun merged commit c27bee7 into reactjs:master Mar 13, 2020
@tesseralis tesseralis mentioned this pull request Mar 13, 2020
98 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge push the merge button :)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants