Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translated HOC Page #286

Merged
merged 8 commits into from Feb 25, 2021
Merged

Translated HOC Page #286

merged 8 commits into from Feb 25, 2021

Conversation

dev-hikun
Copy link
Contributor

@dev-hikun dev-hikun commented Feb 16, 2021 •
edited

@netlify
Copy link

netlify bot commented Feb 16, 2021

Deploy preview for ko-reactjs-org ready!

Built with commit 831aa92

https://deploy-preview-286--ko-reactjs-org.netlify.app

@netlify
Copy link

netlify bot commented Feb 16, 2021 •
edited

Deploy preview for ko-reactjs-org ready!

Built with commit 0b2b564

https://deploy-preview-286--ko-reactjs-org.netlify.app

@taehwanno taehwanno mentioned this pull request Feb 16, 2021
Closed
98 tasks
@taehwanno
Copy link
Member

리뷰는 미리 배정받으신 분의 의사를 먼저 확인한 뒤에 진행하도록 하겠습니다 ㅎㅎ

Ref: #1 (comment)

@taehwanno
Copy link
Member

#1 (comment) 미리 배정받으셨던 분이 허락해주셔서 리뷰 진행하도록 할게용
예전에 진행하다가 중단됐던 #187 도 연결시켜 둘게요 ㅎㅎ 몇 가지 리뷰 코멘트가 있으니 참고 부탁드리겠습니당

cc @junsikshim

@taehwanno taehwanno added the needs review Needs review A pull request ready to be reviewed label Feb 16, 2021
@dev-hikun
Copy link
Contributor Author

dev-hikun commented Feb 17, 2021 •
edited

@taehwanno @junsikshim 감사합니다!
저도 #187 보면서 진행했습니다

junsikshim
junsikshim reviewed Feb 17, 2021
View reviewed changes
Copy link
Contributor

@junsikshim junsikshim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 작업했던 내용과 비교해서 커멘트를 남겼습니다~

content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
@taehwanno taehwanno added needs author response Changes requested needing author's input and removed needs review Needs review A pull request ready to be reviewed labels Feb 17, 2021
hg-pyun
hg-pyun reviewed Feb 17, 2021
View reviewed changes
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
hg-pyun
hg-pyun previously approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hg-pyun
Copy link
Member

hg-pyun commented Feb 19, 2021

@junsikshim 확인 한번 부탁드려요!

@hg-pyun hg-pyun added needs review Needs review A pull request ready to be reviewed and removed needs author response Changes requested needing author's input labels Feb 20, 2021
junsikshim
junsikshim reviewed Feb 21, 2021
View reviewed changes
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
@hg-pyun hg-pyun added needs author response Changes requested needing author's input and removed needs review Needs review A pull request ready to be reviewed labels Feb 22, 2021
@dev-hikun
Update higher-order-components.md
33c878f 
오탈자 수정 및 리뷰 적용
@dev-hikun
Copy link
Contributor Author

@junsikshim 좋은 리뷰들 감사합니다. 적용되었습니다.
@hg-pyun @taehwanno 확인 부탁드리겠습니다 :-)

hg-pyun
hg-pyun approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dev-hikun @junsikshim 두분 모두 고생하셨습니다!
LGTM

@hg-pyun hg-pyun added ready to merge push the merge button :) and removed needs author response Changes requested needing author's input labels Feb 25, 2021
@hg-pyun hg-pyun merged commit b88c44e into reactjs:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junsikshim junsikshim junsikshim approved these changes

@hg-pyun hg-pyun hg-pyun approved these changes

Assignees
No one assigned
Labels
ready to merge push the merge button :)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dev-hikun @taehwanno @hg-pyun @junsikshim