Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate React Without ES6 #29

Merged
merged 11 commits into from Mar 14, 2019
Merged

Translate React Without ES6 #29

merged 11 commits into from Mar 14, 2019

Conversation

ymin1103
Copy link
Contributor

@ymin1103 ymin1103 commented Feb 15, 2019

React Without ES6 문서를 번역했습니다.
피드백은 감사히 받겠습니다.

@tesseralis tesseralis mentioned this pull request Feb 15, 2019
98 tasks
@taehwanno
Copy link
Member

taehwanno commented Feb 15, 2019

@ymin1103 먼저 번역에 참여해주셔서 감사합니다. #1 이슈의 번역 과정에서 알 수 있듯이 문서 번역시 필요한 절차가 있습니다. 다른 번역자와의 중복 번역을 방지하기 위해 다음부터는 #1 에 번역을 원하시는 글을 먼저 코멘트로 달아주시면 감사하겠습니다. 또한 "Core Pages"에 속하는 섹션을 먼저 번역하려하니 참고 부탁드립니다. 빠른 시일 내에 리뷰어들이 검토하도록 하겠습니다.

First of all, thank you for participating in the translation. As you can see "For New Translators" in #1 description, there is a process for the translation. To prevent duplicate work with other translators, please let us know in a comment #1 when you're working on a page. Also, we'd like to focus on the sections listed under "Core Pages". Reviewers will review it as soon as possible.

@ymin1103
Copy link
Contributor Author

메인 문서를 참고하지 못하여 숙지하지 못한 채 참여한 점 사과드립니다. 다음에는 core page를 위주로 기여하도록 하겠습니다. 친절한 코멘트에 감사드립니다.

@taggon
Copy link
Collaborator

taggon commented Feb 15, 2019

아직 작업중인 문서이긴 하지만 모범 사례도 한 번 확인해 보신 후 필요한 내용은 적용해주세요. :)
#27

content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Feb 23, 2019

Deploy preview for ko-reactjs-org ready!

Built with commit 53bc084

https://deploy-preview-29--ko-reactjs-org.netlify.com

content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
content/docs/react-without-es6.md Outdated Show resolved Hide resolved
@taehwanno taehwanno added the needs author response Changes requested needing author's input label Feb 28, 2019
@taehwanno
Copy link
Member

@ymin1103 몇 개의 코멘트에 thumbs up 이모지가 달려있지 않네요. 혹시 누락된 거라면 Load more을 누르셔서 확인 부탁드려요. 또한 수정하셨다면 커밋 푸쉬하셨는지 확인 부탁드려요 :)

@ymin1103
Copy link
Contributor Author

ymin1103 commented Mar 9, 2019

검토하다가 커밋 푸시를 못해놨었네요. 우선 지금까지 수정된 사항 반영하여 푸시하였습니다.

@taehwanno
Copy link
Member

@ymin1103 질문 남겨주신 것에 의견 드렸어요. 거의 다 된 것 같네요 :)
남은 부분 수정하셔서 푸쉬 부탁드릴게요.

@ymin1103
Copy link
Contributor Author

마지막 질문 관련 내용 수정 후 푸시하였습니다!

@taehwanno
Copy link
Member

몇 가지 수정사항에 대해 직접 수정해서 푸쉬했습니다 :)

taehwanno
taehwanno previously approved these changes Mar 14, 2019
@taehwanno taehwanno added needs +1 approval and removed needs author response Changes requested needing author's input labels Mar 14, 2019
@simsim0709
Copy link
Collaborator

defaultProps을 -> defaultProps를로,
@taehwanno 님이 코멘트 달아놓은 오브젝트 내에서 -> 객체 내에서로 직접 수정 했습니다.

@taehwanno 님이 리뷰 승인 해놓은 상태여서 머지 하겠습니다.

@simsim0709 simsim0709 merged commit 6b92185 into reactjs:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants