Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Introducing Hooks #33

Merged
merged 13 commits into from May 8, 2019
Merged

Translate Introducing Hooks #33

merged 13 commits into from May 8, 2019

Conversation

ESTAID
Copy link
Contributor

@ESTAID ESTAID commented Feb 16, 2019

피드백주시면 수정하도록 하겠습니다 :)

ellemedit
ellemedit reviewed Feb 16, 2019
View reviewed changes
Copy link
Contributor

@ellemedit ellemedit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

메인테이너는 아니지만 필요해보이는 수정사항을 참조와 함께 남겼습니다.

@tesseralis tesseralis mentioned this pull request Feb 17, 2019
Closed
98 tasks
taggon
taggon reviewed Feb 17, 2019
View reviewed changes
Copy link
Collaborator

@taggon taggon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전체적으로 번역투 문장과 오역이 적잖이 눈에 띕니다.
일부에만 코멘트를 추가했으므로 코멘트 내용과 모범 사례(#27)를 참고하여 전반적으로 손을 보시면 좋을 것 같습니다.

content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
taggon
taggon reviewed Feb 17, 2019
View reviewed changes
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Feb 23, 2019 •
edited

Deploy preview for ko-reactjs-org ready!

Built with commit 9cc5203

https://deploy-preview-33--ko-reactjs-org.netlify.com

@taehwanno taehwanno added needs review Needs review A pull request ready to be reviewed needs +1 approval and removed needs review Needs review A pull request ready to be reviewed labels Feb 28, 2019
taehwanno
taehwanno reviewed Mar 10, 2019
View reviewed changes
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated Show resolved Hide resolved
content/docs/hooks-intro.md Outdated
* **Completely opt-in.** You can try Hooks in a few components without rewriting any existing code. But you don't have to learn or use Hooks right now if you don't want to.
* **100% backwards-compatible.** Hooks don't contain any breaking changes.
* **Available now.** Hooks are now available with the release of v16.8.0.
얘기하기에 앞서, Hooks의 특징은 다음과 같습니다:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문장 끝의 쌍점(:)은 삭제 부탁드려요.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정하였습니다. 감사합니다 :)

content/docs/hooks-intro.md Outdated
## Video Introduction {#video-introduction}

At React Conf 2018, Sophie Alpert and Dan Abramov introduced Hooks, followed by Ryan Florence demonstrating how to refactor an application to use them. Watch the video here:
## 소개영상 {#video-introduction}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

소개 영상

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정하였습니다. 감사합니다 :)

content/docs/hooks-intro.md Outdated

**Crucially, Hooks work side-by-side with existing code so you can adopt them gradually.** There is no rush to migrate to Hooks. We recommend avoiding any "big rewrites", especially for existing, complex class components. It takes a bit of a mindshift to start "thinking in Hooks". In our experience, it's best to practice using Hooks in new and non-critical components first, and ensure that everybody on your team feels comfortable with them. After you give Hooks a try, please feel free to [send us feedback](https://github.com/facebook/react/issues/new), positive or negative.
React 개발자들이 사용하는 API에 초점을 맞추고, 새롭게 출시되는 API에 투자할 시간이 없다는 걸 알고 있습니다. Hooks는 가장 최신 기술이며, 이것은 Hooks를 배우길 고려하거나 적용하기 전에 많은 예제와 튜토리얼을 기다리는 게 나을 수도 있습니다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 출시되는 API -> 출시되는 모든 API
  • 예제 -> 예시
  • 튜토리얼을 -> 자습서를

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정하였습니다. 감사합니다 :)

content/docs/hooks-intro.md Outdated

We intend for Hooks to cover all existing use cases for classes, but **we will keep supporting class components for the foreseeable future.** At Facebook, we have tens of thousands of components written as classes, and we have absolutely no plans to rewrite them. Instead, we are starting to use Hooks in the new code side by side with classes.
우리는 또한 이 원시적인 Hooks를 React에 추가하는 게 쉽지 않다는 것을 알고 있습니다. 궁금해하는 독자들을 위해 동기부여에 대한 구체적인 내용을 담고 있는 [자세한 RFC](https://github.com/reactjs/rfcs/pull/68)를 준비했고 특정 디자인 결정 및 관련 선행 기술에 대한 추가적인 관점을 제공합니다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 우리는 또한 이 원시적인 Hooks를 React에 추가하는 게 쉽지 않다는 것을 알고 있습니다. -> 또한 React에 새로운 기능을 추가하는 기준이 매우 높다는 것을 알고 있습니다.
  • 디자인 -> 설계

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정하였습니다. 감사합니다 :)

content/docs/hooks-intro.md Outdated

We've prepared a [Hooks FAQ page](/docs/hooks-faq.html) that answers the most common questions about Hooks.
현재 존재하고 있는 모든 클래스 사례을 변경하고 싶지만, **미래에도 계속 클래스 컴포넌트들을 지원할 예정입니다.** 페이스북에서 수만 개의 클래스 컴포넌트들을 작성했으며, 그들을 재작성할 계획이 전혀 없습니다. 대신에, 새로운 코드에서 기존 코드와 나란히 Hooks를 사용할 계획입니다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooks가 현재 존재하고 있는 모든 클래스 사용 사례을 다룰 수 있도록 할 생각이지만, 미래에도 계속 클래스 컴포넌트들을 지원할 예정입니다.로 제안드려봐요.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

훨씬 자연스러운거 같네요 !

content/docs/hooks-intro.md Outdated

## Next Steps {#next-steps}
## FAQ {#frequently-asked-questions}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FAQ -> 자주 묻는 질문

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정하였습니다. 감사합니다 :)

content/docs/hooks-intro.md Outdated

By the end of this page, you should have a rough idea of what problems Hooks are solving, but many details are probably unclear. Don't worry! **Let's now go to [the next page](/docs/hooks-overview.html) where we start learning about Hooks by example.**
## 다음 단계 {#next-steps}
이 페이지가 끝에 이르렀을 때 Hooks가 해결하려는 문제들에 대한 대략적인 아이디어를 가지고 있어야만 합니다. 그러나 아직 구체적으로 명확하진 않을 것입니다. 걱정하지 마세요! **[다음 페이지](/docs/hooks-overview.html)로 가서 예제를 통해서 Hooks에 대해 배워 봅시다!**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예제 -> 예시

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정하였습니다. 감사합니다 :)

@taehwanno taehwanno added needs author response Changes requested needing author's input and removed needs +1 approval labels Mar 10, 2019
@gnujoow
Copy link
Member

gnujoow commented Mar 19, 2019

#65 에서는 hooks를 단수형으로 작성하였는데, 두 문서의 용어 통일이 필요해 보입니다.

한국어에서는 단수로 적는것이 더 받아들이기 편하니 단수형으로 통일 하면 어떨까요?

@simsim0709
Copy link
Collaborator

#2 (comment)
여기에 Hook 용어 관련 사항 올려 두었습니다. 참고 바랄게요.

taehwanno
taehwanno reviewed Mar 29, 2019
View reviewed changes
content/docs/hooks-intro.md Outdated
@@ -1,17 +1,16 @@
---
id: hooks-intro
title: Introducing Hooks
title: Hooks의 개요
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 섹션의 제목과 겹치기 때문에 "Hook 소개하기"로 부탁드려요 :)

@taehwanno
Copy link
Member

기존 리뷰 사항 중 몇 가지가 누락되었어요. 아래 그림에 있는 "Load more"을 클릭하셔서 피드백 부탁드려요!

image

@gnujoow
Copy link
Member

gnujoow commented Apr 11, 2019

@Geon-wooBryanKim 진행상황을 알 수 있을까요? :)

hg-pyun
hg-pyun reviewed Apr 23, 2019
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정하신것 같은데 확인부탁드립니다 :)

@hg-pyun hg-pyun added needs review Needs review A pull request ready to be reviewed and removed needs author response Changes requested needing author's input labels Apr 23, 2019
@hg-pyun hg-pyun added needs +1 approval and removed needs review Needs review A pull request ready to be reviewed labels May 3, 2019
@gnujoow gnujoow added ready to merge push the merge button :) and removed needs +1 approval labels May 4, 2019
@hg-pyun hg-pyun merged commit 2072d64 into reactjs:master May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellemedit ellemedit ellemedit left review comments

@taehwanno taehwanno taehwanno left review comments

@hg-pyun hg-pyun hg-pyun approved these changes

@gnujoow gnujoow gnujoow approved these changes

@taggon taggon Awaiting requested review from taggon

Assignees
No one assigned
Labels
ready to merge push the merge button :)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ESTAID @gnujoow @simsim0709 @taehwanno @taggon @ellemedit @hg-pyun