Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render-and-Commit 번역 #394

Merged
merged 3 commits into from Jan 14, 2022
Merged

Render-and-Commit 번역 #394

merged 3 commits into from Jan 14, 2022

Conversation

kimsangyeon
Copy link

@kimsangyeon kimsangyeon commented Dec 13, 2021 •
edited

@github-actions github-actions bot added the beta label Dec 13, 2021
@gnujoow gnujoow added the needs review Needs review A pull request ready to be reviewed label Dec 13, 2021
gnujoow
gnujoow previously approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@gnujoow gnujoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전반적으로 본문의 의미를 잘 옮겨주신것 같습니다. 코멘트에는 개인적인 의견을 추가해보았는데요 한번 확인 해주시면 감사하겠습니다!

beta/src/pages/learn/render-and-commit.md Outdated Show resolved Hide resolved
@gnujoow
Copy link
Member

gnujoow commented Dec 14, 2021

@kimsangyeon pr템플릿에 있는 액션 아이템들을 확인 하시고 진행해주신 다음 check해주시면 감사하겠습니다. :)

@taehwanno taehwanno mentioned this pull request Dec 14, 2021
Closed
@gnujoow gnujoow merged commit 78cb509 into reactjs:main Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnujoow gnujoow gnujoow approved these changes

Assignees
No one assigned
Labels
beta needs review Needs review A pull request ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kimsangyeon @gnujoow @luffy-yeon