Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate: conditional-rendering #399

Merged
merged 6 commits into from Feb 25, 2022
Merged

Translate: conditional-rendering #399

merged 6 commits into from Feb 25, 2022

Conversation

devdubby
Copy link
Contributor

@devdubby devdubby commented Dec 19, 2021 •
edited

@github-actions github-actions bot added the beta label Dec 19, 2021
@devdubby
Copy link
Contributor Author

몇몇 번역투? 의 어색한 문장들이 있는데 먼저 PR을 남깁니다. 한번 확인 후 수정사항 제안해주시면 너무나 감사하겠습니다!

@taehwanno taehwanno added the needs review Needs review A pull request ready to be reviewed label Dec 21, 2021
@hg-pyun
Copy link
Member

hg-pyun commented Dec 22, 2021

바뻐서 리뷰를 못하고있네요 8ㅅ8;; 주말에 시간내서 보겠습니다. 번역 감사합니다 🙇

gnujoow
gnujoow requested changes Jan 6, 2022
View reviewed changes
Copy link
Member

@gnujoow gnujoow left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

원문과 line수가 다른것 같습니다 확인 한번 부탁드립니다.
pr템플릿에 있는 항목들을 다시 한번 확인해주세요

beta/src/pages/learn/conditional-rendering.md Outdated Show resolved Hide resolved
beta/src/pages/learn/conditional-rendering.md Outdated Show resolved Hide resolved
beta/src/pages/learn/conditional-rendering.md Outdated Show resolved Hide resolved
@hg-pyun hg-pyun added needs author response Changes requested needing author's input and removed needs review Needs review A pull request ready to be reviewed labels Jan 22, 2022
@hg-pyun
Copy link
Member

hg-pyun commented Jan 22, 2022

@devdubby 코멘트 확인한번 부탁드립니다 🙇

@devdubby devdubby closed this Jan 22, 2022
@devdubby devdubby reopened this Jan 22, 2022
@devdubby
Copy link
Contributor Author

@hg-pyun @gnujoow
에고... 저번에 리뷰 해주신거 봤는데 이제야 수정 했네요...! 리뷰해주신 내용 모두 반영하여 다시 업데이트 했습니다..! 감사합니다 👍

@gnujoow gnujoow added ready to merge push the merge button :) and removed needs author response Changes requested needing author's input labels Feb 3, 2022
@hg-pyun hg-pyun merged commit 31f04eb into reactjs:main Feb 25, 2022
@taehwanno taehwanno mentioned this pull request Sep 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnujoow gnujoow gnujoow approved these changes

Assignees
No one assigned
Labels
beta ready to merge push the merge button :)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@devdubby @hg-pyun @gnujoow @taehwanno