Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Shallow Renderer #40

Merged
merged 8 commits into from Mar 12, 2019
Merged

Translate Shallow Renderer #40

merged 8 commits into from Mar 12, 2019

Conversation

hmu332233
Copy link
Contributor

@hmu332233 hmu332233 commented Feb 20, 2019 •
edited

Progress

@tesseralis tesseralis mentioned this pull request Feb 20, 2019
Closed
98 tasks
gnujoow
gnujoow previously requested changes Feb 21, 2019
View reviewed changes
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Feb 22, 2019

Deploy preview for ko-reactjs-org ready!

Built with commit e50320c

https://deploy-preview-40--ko-reactjs-org.netlify.com

@netlify
Copy link

netlify bot commented Feb 22, 2019 •
edited

Deploy preview for ko-reactjs-org ready!

Built with commit f42e2a8

https://deploy-preview-40--ko-reactjs-org.netlify.com

@taehwanno
Copy link
Member

upstream과 sync되면서 master 브랜치의 모든 링크 주소가 https로 변경되어 직접 충돌 해결했습니다.

@taehwanno taehwanno added needs review Needs review A pull request ready to be reviewed needs +1 approval and removed needs review Needs review A pull request ready to be reviewed labels Feb 28, 2019
taehwanno
taehwanno reviewed Mar 10, 2019
View reviewed changes
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
@taehwanno taehwanno added needs author response Changes requested needing author's input and removed needs +1 approval labels Mar 10, 2019
@hmu332233
Copy link
Contributor Author

@taehwanno
리뷰 반영했습니다.

다만 62번째 라인에서
테스트를 할 수 있다는 의미합니다. -> 테스트를 할 수 있음을 의미합니다.로 제안해주신 것을
테스트할 수 있음을 의미합니다.로 바꿔보았습니다.

@taehwanno taehwanno added needs +1 approval and removed needs author response Changes requested needing author's input labels Mar 12, 2019
@simsim0709 simsim0709 self-requested a review March 12, 2019 08:53
simsim0709
simsim0709 approved these changes Mar 12, 2019
View reviewed changes
Copy link
Collaborator

@simsim0709 simsim0709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~ 👍

@simsim0709 simsim0709 dismissed gnujoow’s stale review March 12, 2019 08:56

리뷰 반영되어 제가 머지 했습니다.

@simsim0709 simsim0709 merged commit 4fac594 into reactjs:master Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taehwanno taehwanno taehwanno approved these changes

@simsim0709 simsim0709 simsim0709 approved these changes

@gnujoow gnujoow gnujoow left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hmu332233 @taehwanno @simsim0709 @gnujoow