Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate: React DOM Components #606

Merged
merged 6 commits into from May 7, 2023
Merged

Translate: React DOM Components #606

merged 6 commits into from May 7, 2023

Conversation

kangju2000
Copy link
Contributor

@kangju2000 kangju2000 commented May 1, 2023 •
edited

gnujoow
gnujoow requested changes May 2, 2023
View reviewed changes
Copy link
Member

@gnujoow gnujoow left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

쌍점을 대부분 그대로 옮겨주신것 같습니다. 위 문서를 참고하셔서 문서스타일 업데이트를 요청드립니다.

605번 pr에 댓글을 단다는게 잘 못 달았네요. 혼선을 드려 죄송합니다.

gnujoow
gnujoow previously approved these changes May 2, 2023
View reviewed changes
gnujoow
gnujoow reviewed May 2, 2023
View reviewed changes
src/content/reference/react-dom/components/index.md Outdated

This includes React-specific props like `ref` and `dangerouslySetInnerHTML`.
`ref`와 `dangerouslySetInnerHTML`같은 React 특정 props를 포함합니다.
Copy link
Member

@gnujoow gnujoow May 2, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

의견 요청)
React 특정 props이란 표현이 React-specific props인지, 혹은 props를 일컫는것인지 중의적으로 해석 될 수 있습니다.
위 용어를 React만의 props 혹은. 리액트 고유 props 등으로 수정을 해보면 어떨까요? 혹은 영문 병기를 하면 어떨까요?

Copy link
Contributor Author

@kangju2000 kangju2000 May 3, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확실히 React 특정 props는 중의적으로 해석될 수 있겠네요🤔
React 고유의 props로 바꾸었습니다 :)

@gnujoow gnujoow self-requested a review May 2, 2023 19:34
MaxKim-J
MaxKim-J approved these changes May 6, 2023
View reviewed changes
Copy link
Collaborator

@MaxKim-J MaxKim-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@gnujoow gnujoow merged commit 2040050 into reactjs:main May 7, 2023
2 checks passed
@hg-pyun hg-pyun mentioned this pull request May 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxKim-J MaxKim-J MaxKim-J approved these changes

@hg-pyun hg-pyun Awaiting requested review from hg-pyun hg-pyun is a code owner

@taehwanno taehwanno Awaiting requested review from taehwanno taehwanno is a code owner

@simsim0709 simsim0709 Awaiting requested review from simsim0709 simsim0709 is a code owner

@b9words b9words Awaiting requested review from b9words b9words is a code owner

@taggon taggon Awaiting requested review from taggon taggon is a code owner

@eomttt eomttt Awaiting requested review from eomttt eomttt is a code owner

@goofcode goofcode Awaiting requested review from goofcode

@gnujoow gnujoow Awaiting requested review from gnujoow gnujoow is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kangju2000 @gnujoow @MaxKim-J