Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Uncontrolled Components #66

Merged
merged 8 commits into from Apr 4, 2019
Merged

Translate Uncontrolled Components #66

merged 8 commits into from Apr 4, 2019

Conversation

hyunalee419
Copy link
Contributor

@hyunalee419 hyunalee419 commented Mar 10, 2019 •
edited by taehwanno

Progress

hyunalee419
hyunalee419 commented Mar 10, 2019
View reviewed changes
content/docs/uncontrolled-components.md Outdated

`embed:uncontrolled-components/input-type-file.js`

[](codepen://uncontrolled-components/input-type-file)
[CodePen에서 실행하기](codepen://uncontrolled-components/input-type-file)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제 로컬에서 **를 붙여 [**CodePen에서 실행하기**]로 작성하면 undefined로 보여 위같이 작성했습니다. 확인 부탁드립니다.

@netlify
Copy link

netlify bot commented Mar 10, 2019

Deploy preview for ko-reactjs-org ready!

Built with commit c7017ee

https://deploy-preview-66--ko-reactjs-org.netlify.com

@netlify
Copy link

netlify bot commented Mar 10, 2019 •
edited

Deploy preview for ko-reactjs-org ready!

Built with commit 9a93d0d

https://deploy-preview-66--ko-reactjs-org.netlify.com

@simsim0709 simsim0709 added the needs review Needs review A pull request ready to be reviewed label Mar 10, 2019
@tesseralis tesseralis mentioned this pull request Mar 10, 2019
Closed
98 tasks
@simsim0709 simsim0709 added needs author response Changes requested needing author's input and removed needs review Needs review A pull request ready to be reviewed labels Mar 15, 2019
@taehwanno taehwanno mentioned this pull request Mar 22, 2019
Closed
6 tasks
simsim0709
simsim0709 previously approved these changes Mar 28, 2019
View reviewed changes
Copy link
Collaborator

@simsim0709 simsim0709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~ 👍

@simsim0709 simsim0709 added needs +1 approval and removed needs author response Changes requested needing author's input labels Mar 28, 2019
@taehwanno
Copy link
Member

몇 가지 직접 수정했어요. 고생하셨습니다 :)

@taehwanno taehwanno merged commit a1c0a45 into reactjs:master Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simsim0709 simsim0709 simsim0709 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hyunalee419 @taehwanno @simsim0709