Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate refs-must-have-owner #69

Merged

Conversation

simsim0709
Copy link
Collaborator

Progress

@simsim0709 simsim0709 added the needs review Needs review A pull request ready to be reviewed label Mar 10, 2019
@tesseralis tesseralis mentioned this pull request Mar 10, 2019
98 tasks
@netlify
Copy link

netlify bot commented Mar 10, 2019

Deploy preview for ko-reactjs-org ready!

Built with commit 385c7cb

https://deploy-preview-69--ko-reactjs-org.netlify.com

Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hg-pyun hg-pyun added needs +1 approval and removed needs review Needs review A pull request ready to be reviewed labels Apr 16, 2019
>
> addComponentAsRefTo(...): Only a ReactOwner can have refs. You might be adding a ref to a component that was not created inside a component's `render` method, or you have multiple copies of React loaded.
>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

19 20행은 삭제되어야 할 것 같아요

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

실제 경고 문구는 그대로 유지 하라고 해서 남겨 두었어요~

@gnujoow gnujoow added needs author response Changes requested needing author's input and removed needs +1 approval labels May 4, 2019
@simsim0709 simsim0709 requested a review from gnujoow May 4, 2019 08:14
@simsim0709 simsim0709 added needs +1 approval and removed needs author response Changes requested needing author's input labels May 4, 2019
@gnujoow gnujoow added ready to merge push the merge button :) and removed needs +1 approval labels May 6, 2019
@simsim0709 simsim0709 merged commit 7147f9b into reactjs:master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge push the merge button :)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants